Skip to content

Commit 07ab621

Browse files
committed
fix(rollup): improve circular dependency warning handling
1 parent ba46429 commit 07ab621

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

rollup.config.build.mjs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@ export default {
1919
terser()
2020
],
2121
onwarn: function(warning, warner){
22-
if (warning.code === 'CIRCULAR_DEPENDENCY'){
23-
if(warning.importer && warning.importer.startsWith('node_modules')){
24-
return;
25-
}
22+
if (warning.code === 'CIRCULAR_DEPENDENCY') {
23+
if (warning.importer && warning.importer.startsWith('node_modules')) {
24+
console.warn(`(!) Circular dependency: ${warning.importer}`);
25+
}
26+
} else {
27+
warner(warning);
2628
}
27-
warner(warning);
2829
}
2930
};

rollup.config.dev.mjs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ export default {
2323
})
2424
],
2525
onwarn: function(warning, warner){
26-
if (warning.code === 'CIRCULAR_DEPENDENCY'){
27-
if(warning.importer && warning.importer.startsWith('node_modules')){
28-
return;
29-
}
26+
if (warning.code === 'CIRCULAR_DEPENDENCY') {
27+
if (warning.importer && warning.importer.startsWith('node_modules')) {
28+
console.warn(`(!) Circular dependency: ${warning.importer}`);
29+
}
30+
} else {
31+
warner(warning);
3032
}
31-
warner(warning);
3233
}
3334
};

0 commit comments

Comments
 (0)