.

Author: ahmadsharif1

.github/workflows/linux_cuda_wheel.yaml

@@ -63,7 +63,7 @@ jobs:
       matrix:
         python-version: ['3.9', '3.10', '3.11', '3.12']
         cuda-version: ['12.4']
-        ffmpeg-version-for-tests: ['6']
+        ffmpeg-version-for-tests: ['5', '6', '7']
     container:
       image: "pytorch/manylinux-builder:cuda${{ matrix.cuda-version }}"
       options: "--gpus all -e NVIDIA_DRIVER_CAPABILITIES=video,compute,utility"
@@ -76,8 +76,8 @@ jobs:
           echo cuda_version_without_periods=${cuda_version_without_periods} >> $GITHUB_ENV
       - uses: actions/download-artifact@v3
         with:
-          # This was originally:
-          # name: pytorch_torchcodec__${{ matrix.python-version }}_cu${{ env.cuda_version_without_periods }}_x86_64
+          # We use 3.9 because it's the minimum version we build.
+          # We test version 3.9 against all other python versions in the matrix.
           name: pytorch_torchcodec__3.9_cu${{ env.cuda_version_without_periods }}_x86_64
           path: pytorch/torchcodec/dist/
       - name: Setup miniconda using test-infra
@@ -95,7 +95,6 @@ jobs:
       - name: Install PyTorch
         run: |
           ${CONDA_RUN} python -m pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu${{ env.cuda_version_without_periods }}
-          # ${CONDA_RUN} python -m pip install torch torchvision torchaudio
           ${CONDA_RUN} python -c 'import torch; print(f"{torch.__version__}"); print(f"{torch.__file__}"); print(f"{torch.cuda.is_available()=}")'
       - name: Install torchcodec from the wheel
         run: |
@@ -105,25 +104,6 @@ jobs:
 
       - name: Check out repo
         uses: actions/checkout@v3
-      - name: Build & install ffmpeg after installing torchcodec
-        run: |
-          # Ideally we would have checked for that before installing the wheel,
-          # but we need to checkout the repo to access this file, and we don't
-          # want to checkout the repo before installing the wheel to avoid any
-          # side-effect. It's OK.
-          # source packaging/helpers.sh
-          # assert_ffmpeg_not_installed
-          # It seems like conda can't install ffmpeg cleanly in many cases. So we just build it from source.
-
-          # ${CONDA_RUN} conda install --yes ffmpeg=${{ matrix.ffmpeg-version-for-tests }} -vv -c conda-forge
-          # ${CONDA_RUN} conda install --yes conda
-          # ${CONDA_RUN} conda update --all --yes
-          # ${CONDA_RUN} conda config --add channels conda-forge
-          # ${CONDA_RUN} conda config --set channel_priority strict
-          # ${CONDA_RUN} conda config --show
-          # ${CONDA_RUN} $CONDA_PREFIX/bin/conda install --yes ffmpeg=${{ matrix.ffmpeg-version-for-tests }} -c conda-forge
-          # ${CONDA_INSTALL} --yes ffmpeg=${{ matrix.ffmpeg-version-for-tests }} -c conda-forge
-          # ${CONDA_RUN} conda install --yes ffmpeg=${{ matrix.ffmpeg-version-for-tests }} -c conda-forge
 
       - name: Install cuda runtime dependencies
         run: |
@@ -150,14 +130,6 @@ jobs:
           ls
       - name: Smoke test
         run: |
-          ${CONDA_RUN} find $CONDA_PREFIX -name libav\*.so | xargs ldd
-          ${CONDA_RUN} find $CONDA_PREFIX -name libav\*.so | xargs readelf -d
-          ${CONDA_RUN} find / -name libnvcuvid\*
-          find / -name libnvcuvid\*
-          ${CONDA_RUN} find $CONDA_PREFIX -name libtorchcodec\*.so | xargs ldd
-          ${CONDA_RUN} find $CONDA_PREFIX -name libtorchcodec\*.so | xargs readelf -d
-          ${CONDA_RUN} find $CONDA_PREFIX -name libcuda\*.so\*
-          ${CONDA_RUN} echo $CONDA_PREFIX
           ${CONDA_RUN} python test/decoders/manual_smoke_test.py
       - name: Run Python tests
         run: |