Skip to content

Commit b942423

Browse files
authored
Relax test constraint for ffmpeg versions as they can be arbitrary (#308)
1 parent 650e8bf commit b942423

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/linux_cuda_wheel.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,7 @@ jobs:
135135
${CONDA_RUN} python test/decoders/manual_smoke_test.py
136136
- name: Run Python tests
137137
run: |
138-
# We skip test_get_ffmpeg_version because it may not have a micro version.
139-
${CONDA_RUN} FAIL_WITHOUT_CUDA=1 pytest test -k "not test_get_ffmpeg_version" -vvv
138+
${CONDA_RUN} FAIL_WITHOUT_CUDA=1 pytest test -vvv
140139
- name: Run Python benchmark
141140
run: |
142141
${CONDA_RUN} time python benchmarks/decoders/gpu_benchmark.py --devices=cuda:0,cpu --resize_devices=none

test/decoders/test_video_decoder_ops.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -423,9 +423,7 @@ def test_get_ffmpeg_version(self):
423423
# The earliest libavutil version is 50 as per:
424424
# https://www.ffmpeg.org/olddownload.html
425425
assert ffmpeg_dict["libavutil"][0] > 50
426-
ffmpeg_version = ffmpeg_dict["ffmpeg_version"]
427-
split_ffmpeg_version = [int(num) for num in ffmpeg_version.split(".")]
428-
assert len(split_ffmpeg_version) == 3
426+
assert "ffmpeg_version" in ffmpeg_dict
429427

430428
def test_frame_pts_equality(self):
431429
decoder = create_from_file(str(NASA_VIDEO.path))

0 commit comments

Comments
 (0)