From bba635381613548a669bf2fa9fdf588bf644194e Mon Sep 17 00:00:00 2001 From: Nicolas Hug Date: Thu, 10 Apr 2025 10:07:43 +0100 Subject: [PATCH] bit_rate -> bitRate --- src/torchcodec/_core/Encoder.cpp | 8 ++++---- src/torchcodec/_core/Encoder.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/torchcodec/_core/Encoder.cpp b/src/torchcodec/_core/Encoder.cpp index 711be8b7..99628f90 100644 --- a/src/torchcodec/_core/Encoder.cpp +++ b/src/torchcodec/_core/Encoder.cpp @@ -41,7 +41,7 @@ AudioEncoder::AudioEncoder( const torch::Tensor wf, int sampleRate, std::string_view fileName, - std::optional bit_rate) + std::optional bitRate) : wf_(wf) { TORCH_CHECK( wf_.dtype() == torch::kFloat32, @@ -82,12 +82,12 @@ AudioEncoder::AudioEncoder( TORCH_CHECK(avCodecContext != nullptr, "Couldn't allocate codec context."); avCodecContext_.reset(avCodecContext); - if (bit_rate.has_value()) { - TORCH_CHECK(*bit_rate >= 0, "bit_rate=", *bit_rate, " must be >= 0."); + if (bitRate.has_value()) { + TORCH_CHECK(*bitRate >= 0, "bit_rate=", *bitRate, " must be >= 0."); } // bit_rate=None defaults to 0, which is what the FFmpeg CLI seems to use as // well when "-b:a" isn't specified. - avCodecContext_->bit_rate = bit_rate.value_or(0); + avCodecContext_->bit_rate = bitRate.value_or(0); validateSampleRate(*avCodec, sampleRate); avCodecContext_->sample_rate = sampleRate; diff --git a/src/torchcodec/_core/Encoder.h b/src/torchcodec/_core/Encoder.h index 830c3552..cccab2b2 100644 --- a/src/torchcodec/_core/Encoder.h +++ b/src/torchcodec/_core/Encoder.h @@ -20,7 +20,7 @@ class AudioEncoder { // encoding will still work but audio will be distorted. int sampleRate, std::string_view fileName, - std::optional bit_rate = std::nullopt); + std::optional bitRate = std::nullopt); void encode(); private: