Skip to content

Commit 0cb88b4

Browse files
authored
chore(nodejs): run linter in build (#1)
1 parent a174f4f commit 0cb88b4

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ jobs:
2424
- name: Run tests
2525
run: npm test
2626

27+
- name: Run linter
28+
run: npm run eslint
29+
2730
- name: Publish @questdb/nodejs-questdb-client to npm
2831
if: github.ref == 'refs/heads/main'
2932
uses: JS-DevTools/npm-publish@v1

notes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- ~~Provide a builder style API:
1010
builder.table('tab').symbol('symName', any).intColumn('intCol', 34).timestampColumn('tsCol', 23232323).atNow();~~
1111
- ~~The project lacks a linter. Use ESLint (https://eslint.org) or standard (https://standardjs.com)~~
12+
- ~~Run linter in build~~
1213
- ~~Move certs/ under test/ since these are test specific files. Possibly generate certs from test.~~
1314
- Test the client against a real QuestDB instance, not only mock. The easiest way to do it is to use https://www.npmjs.com/package/testcontainers
1415
- ~~authenticate() function doesn't await for sender.socket.write() to happen and doesn't check for errors~~

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"types": "types/index.d.ts",
77
"scripts": {
88
"test": "jest",
9+
"eslint": "npx eslint src/**",
910
"docs": "jsdoc index.js src/sender.js README.md -d docs"
1011
},
1112
"repository": {

0 commit comments

Comments
 (0)