-
Notifications
You must be signed in to change notification settings - Fork 2.6k
What if a health check fails? #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @0xWJ , do you have retries enabled for your Redis client or are you using the default config? One more important details - what client are you using - sync, async, standalone, cluster? |
Thanks. It is very troublesome to make it work in a not-very-reliable network. At first, I just use
And it hangs sometimes (redis op never returns). Then I update it to
But it still hangs sometimes with less chance and raise connection error (timeout or broken pipeline). So I then change it to
This time no hang happens (at less until now), but still raise error sometimes. So I try health check
Looks it can't mitigate the problem. You mean health check only work with retry? I am wondering do you guys have recommended options that work best in a bad network? |
@0xWJ in case any of the calls during the communication with Redis fails - an error will be raised, and if you don't have a retry configuration applied - nothing will be retried - you will just see the raised error. |
No problem. I will do it. Hope you can point out how the health check should be used. in your document. |
Hi @0xWJ, did you have some time to test with the retry config enabled? One more thing you can try now is to run with the latest release - it has retries enabled by default.. |
Thank you for you quick response. I will try it. |
I encountered a health check fail. My assumption is when a health check fails, it should abandon the current connection and make a new connection to the redis server.
But turns out it will just throw the failure? Am I missing something or this is by design?
The text was updated successfully, but these errors were encountered: