Merge pull request #145 from retailcoder/config

ConfigurationLoader automatically adds newly implemented Code Inspections to Config

Author: rubberduck203

RetailCoder.VBE/Config/ConfigurationLoader.cs

@@ -27,7 +27,7 @@ public void SaveConfiguration<T>(T toSerialize)
         }
 
         /// <summary>   Loads the configuration from Rubberduck.config xml file. </summary>
-        /// <remarks> If an IOException occurs returns a default configuration.</remarks>
+        /// <remarks> If an IOException occurs, returns a default configuration.</remarks>
         public Configuration LoadConfiguration()
         {
             try
@@ -49,7 +49,11 @@ public Configuration LoadConfiguration()
                         config.UserSettings.CodeInspectionSettings = new CodeInspectionSettings(GetDefaultCodeInspections());
                     }
 
-                    //todo: check for implemented inspections that aren't in config file
+                    var implementedInspections = GetImplementedCodeInspections();
+                    var configInspections = config.UserSettings.CodeInspectionSettings.CodeInspections.ToList();
+                    
+                    configInspections = MergeImplementedInspectionsNotInConfig(configInspections, implementedInspections);
+                    config.UserSettings.CodeInspectionSettings.CodeInspections = configInspections.ToArray();
 
                     return config;
                 }
@@ -80,6 +84,29 @@ public Configuration LoadConfiguration()
             }
         }
 
+        private List<CodeInspection> MergeImplementedInspectionsNotInConfig(List<CodeInspection> configInspections, IList<IInspection> implementedInspections)
+        {
+            bool found;
+            foreach (var implementedInspection in implementedInspections)
+            {
+                found = false;
+                foreach (var configInspection in configInspections)
+                {
+                    if (implementedInspection.Name == configInspection.Name)
+                    {
+                        found = true;
+                        break;
+                    }
+                }
+
+                if (!found)
+                {
+                    configInspections.Add(new CodeInspection(implementedInspection));
+                }
+            }
+            return configInspections;
+        }
+
         public Configuration GetDefaultConfiguration()
         {
             var userSettings = new UserSettings(

RetailCoder.VBE/Config/IConfigurationService.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Runtime.InteropServices;
+using System.Collections.Generic;
 
 namespace Rubberduck.Config
 {
@@ -9,8 +10,8 @@ public interface IConfigurationService
         CodeInspection[] GetDefaultCodeInspections();
         Configuration GetDefaultConfiguration();
         ToDoMarker[] GetDefaultTodoMarkers();
-        System.Collections.Generic.IList<Rubberduck.Inspections.IInspection> GetImplementedCodeInspections();
-        System.Collections.Generic.List<Rubberduck.VBA.Parser.Grammar.ISyntax> GetImplementedSyntax();
+        IList<Rubberduck.Inspections.IInspection> GetImplementedCodeInspections();
+        List<Rubberduck.VBA.Parser.Grammar.ISyntax> GetImplementedSyntax();
         Configuration LoadConfiguration();
         void SaveConfiguration<T>(T toSerialize);
     }