Skip to content

Commit a30aeed

Browse files
committed
Refactor FakesProvider.SuspendFake and .ResumeFake to do type comparisons rather than string comparisons
1 parent 1ecc58d commit a30aeed

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

Rubberduck.Main/ComClientLibrary/UnitTesting/Fakes/Date.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ public void DateCallback(IntPtr retVal)
2424
}
2525
if (PassThrough)
2626
{
27-
FakesProvider.SuspendFake("Now");
27+
FakesProvider.SuspendFake(typeof(Now));
2828
var nativeCall = Marshal.GetDelegateForFunctionPointer<DateDelegate>(NativeFunctionAddress);
2929
nativeCall(retVal);
30-
FakesProvider.ResumeFake("Now");
30+
FakesProvider.ResumeFake(typeof(Now));
3131
return;
3232
}
3333
Marshal.GetNativeVariantForObject(ReturnValue ?? 0, retVal);

Rubberduck.Main/ComClientLibrary/UnitTesting/Fakes/Time.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ public void TimeCallback(IntPtr retVal)
2424
}
2525
if (PassThrough)
2626
{
27-
FakesProvider.SuspendFake("Now");
27+
FakesProvider.SuspendFake(typeof(Now));
2828
var nativeCall = Marshal.GetDelegateForFunctionPointer<TimeDelegate>(NativeFunctionAddress);
2929
nativeCall(retVal);
30-
FakesProvider.ResumeFake("Now");
30+
FakesProvider.ResumeFake(typeof(Now));
3131
return;
3232
}
3333
Marshal.GetNativeVariantForObject(ReturnValue ?? 0, retVal);

Rubberduck.Main/ComClientLibrary/UnitTesting/FakesProvider.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,23 +37,23 @@ public void StartTest()
3737
CodeIsUnderTest = true;
3838
}
3939

40-
public static void SuspendFake(String typename)
40+
public static void SuspendFake(Type type)
4141
{
4242
foreach (var fake in ActiveFakes.Values)
4343
{
44-
if (fake.GetType().Name == typename)
44+
if (fake.GetType() == type)
4545
{
4646
fake.DisableHook();
4747
return;
4848
}
4949
}
5050
}
5151

52-
public static void ResumeFake(String typename)
52+
public static void ResumeFake(Type type)
5353
{
5454
foreach (var fake in ActiveFakes.Values)
5555
{
56-
if (fake.GetType().Name == typename)
56+
if (fake.GetType() == type)
5757
{
5858
fake.EnableHook();
5959
return;

0 commit comments

Comments
 (0)