Revert "docking UI for source control."

This reverts commit f71cb70.

Author: rubberduck203

RetailCoder.VBE/Rubberduck.csproj

@@ -204,7 +204,6 @@
       <DependentUpon>ExtractMethodDialog.cs</DependentUpon>
     </Compile>
     <Compile Include="UI\Refactorings\ExtractMethod\ValueChangedEventArgs.cs" />
-    <Compile Include="UI\SourceControl\GitHubSourceControlDockablePresenter.cs" />
     <Compile Include="UI\SourceControl\SourceControlPanel.cs">
       <SubType>UserControl</SubType>
     </Compile>

RetailCoder.VBE/UI/CodeInspections/CodeInspectionsDockablePresenter.cs

@@ -13,7 +13,7 @@ public class CodeInspectionsDockablePresenter : DockablePresenterBase
         private CodeInspectionsWindow Control { get { return UserControl as CodeInspectionsWindow; } }
 
         private IList<ICodeInspectionResult> _results;
-        private readonly IInspector _inspector;
+        private IInspector _inspector;
 
         public CodeInspectionsDockablePresenter(IInspector inspector, VBE vbe, AddIn addin, CodeInspectionsWindow window)
             :base(vbe, addin, window)

RetailCoder.VBE/UI/CodeInspections/CodeInspectionsMenu.cs

@@ -11,17 +11,20 @@ namespace Rubberduck.UI.CodeInspections
 {
     public class CodeInspectionsMenu : Menu
     {
-        private readonly CodeInspectionsDockablePresenter _presenter; //if presenter goes out of scope, so does its toolwindow Issue #169
+        private CommandBarButton _codeInspectionsButton;
+        private readonly CodeInspectionsWindow _window;
+        private readonly CodeInspectionsDockablePresenter _presenter; //if presenter goes out of scope, so does it's toolwindow Issue #169
 
-        public CodeInspectionsMenu(VBE vbe, AddIn addIn, CodeInspectionsDockablePresenter presenter)
+        public CodeInspectionsMenu(VBE vbe, AddIn addIn, CodeInspectionsWindow view, CodeInspectionsDockablePresenter presenter)
             :base(vbe, addIn)
         {
+            _window = view;
             _presenter = presenter;
         }
 
         public void Initialize(CommandBarPopup parentMenu)
         {
-            AddButton(parentMenu, "Code &Inspections", false, new CommandBarButtonClickEvent(OnCodeInspectionsButtonClick));
+            _codeInspectionsButton = AddButton(parentMenu, "Code &Inspections", false, new CommandBarButtonClickEvent(OnCodeInspectionsButtonClick));
         }
 
         private void OnCodeInspectionsButtonClick(CommandBarButton ctrl, ref bool canceldefault)

RetailCoder.VBE/UI/DockablePresenterBase.cs

@@ -11,12 +11,12 @@ public abstract class DockablePresenterBase : IDisposable
         private Window _window;
         protected readonly UserControl UserControl;
 
-        protected DockablePresenterBase(VBE vbe, AddIn addin, IDockableUserControl window)
+        protected DockablePresenterBase(VBE vbe, AddIn addin, IDockableUserControl control)
         {
             _vbe = vbe;
             _addin = addin;
-            UserControl = window as UserControl;
-            _window = CreateToolWindow(window);
+            UserControl = control as UserControl;
+            _window = CreateToolWindow(control);
         }
 
         private readonly VBE _vbe;

RetailCoder.VBE/UI/RubberduckMenu.cs

@@ -24,8 +24,6 @@ public class RubberduckMenu : Menu
         private readonly RefactorMenu _refactorMenu;
         private readonly IConfigurationService _configService;
 
-        private DockablePresenterBase _sourceControlPresenter;
-
         public RubberduckMenu(VBE vbe, AddIn addIn, IConfigurationService configService, IRubberduckParser parser, IInspector inspector)
             : base(vbe, addIn)
         {
@@ -47,10 +45,7 @@ public RubberduckMenu(VBE vbe, AddIn addIn, IConfigurationService configService,
 
             var inspectionExplorer = new CodeInspectionsWindow();
             var inspectionPresenter = new CodeInspectionsDockablePresenter(inspector, vbe, addIn, inspectionExplorer);
-            _codeInspectionsMenu = new CodeInspectionsMenu(vbe, addIn, inspectionPresenter);
-
-            var sourceControlPanel = new SourceControlPanel();
-            _sourceControlPresenter = new GitHubSourceControlDockablePresenter(vbe, addIn, sourceControlPanel);
+            _codeInspectionsMenu = new CodeInspectionsMenu(vbe, addIn, inspectionExplorer, inspectionPresenter);
 
             _refactorMenu = new RefactorMenu(IDE, addInInstance, parser);
         }
@@ -76,7 +71,7 @@ public void Initialize()
             _codeInspectionsMenu.Initialize(menu);
 
             //note: disabled for 1.2 release
-            //_sourceControl = AddButton(menu, "Source Control", false, OnSourceControlClick);
+            //_sourceControl = AddButton(menu, "Source Control", false, new CommandBarButtonClickEvent(OnSourceControlClick));
 
             _settings = AddButton(menu, "&Options", true, OnOptionsClick);
             _about = AddButton(menu, "&About...", true, OnAboutClick);
@@ -85,7 +80,10 @@ public void Initialize()
 
         private void OnSourceControlClick(CommandBarButton Ctrl, ref bool CancelDefault)
         {
-            _sourceControlPresenter.Show();
+            using (var window = new DummyGitView(IDE.ActiveVBProject))
+            {
+                window.ShowDialog();
+            }
         }
 
         private void OnOptionsClick(CommandBarButton Ctrl, ref bool CancelDefault)
@@ -132,10 +130,6 @@ protected override void Dispose(bool disposing)
                 {
                     _testMenu.Dispose();
                 }
-                if (_sourceControlPresenter != null)
-                {
-                    _sourceControlPresenter.Dispose();
-                }
             }
 
             _disposed = true;

RetailCoder.VBE/UI/SourceControl/GitHubSourceControlDockablePresenter.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Drawing;
 using System.Data;
 using System.Linq;
@@ -8,21 +9,11 @@
 
 namespace Rubberduck.UI.SourceControl
 {
-    public partial class SourceControlPanel : UserControl, IDockableUserControl
+    public partial class SourceControlPanel : UserControl
     {
         public SourceControlPanel()
         {
             InitializeComponent();
         }
-
-        public string ClassId
-        {
-            get { return "19A32FC9-4902-4385-9FE7-829D4F9C441D"; }
-        }
-
-        public string Caption
-        {
-            get { return "Source Control"; }
-        }
     }
 }

RetailCoder.VBE/UI/SourceControl/SourceControlPanel.Designer.cs

@@ -12,8 +12,8 @@ public class TestExplorerDockablePresenter : DockablePresenterBase
         private TestExplorerWindow Control { get { return UserControl as TestExplorerWindow; } }
         private readonly ITestEngine _testEngine;
 
-        public TestExplorerDockablePresenter(VBE vbe, AddIn addin, IDockableUserControl window, ITestEngine testEngine)
-            : base(vbe, addin, window)
+        public TestExplorerDockablePresenter(VBE vbe, AddIn addin, IDockableUserControl control, ITestEngine testEngine)
+            : base(vbe, addin, control)
         {
             _testEngine = testEngine;
             RegisterTestExplorerEvents();

RetailCoder.VBE/UI/SourceControl/SourceControlPanel.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Linq;
+using System.Runtime.InteropServices;
 using System.Windows.Forms;
 using Rubberduck.UnitTesting;