fix-eslint-plugin (#2994)

* fix issues with string template scenarios.
ensure plugin works with modern versions of eslint.
add missing test scenarios.

* run lint:fix

Co-authored-by: Stephen James <sjames@salesforce.com>

Author: gbutt-tr

eslint-plugin/lib/rules/no-double-dash-modifier.js

@@ -39,7 +39,7 @@ module.exports = {
 		const getFixer = (node, getValue, getFixRange) => (fixer) => {
 			const nodeText = getValue(node);
 			const fixedText = nodeText.replace(SLDS_DEPRECATED_CSS_SYNTAX, '$1_$2');
-			const range = getFixRange(node);
+			const range = getFixRange(node.range);
 			return fixer.replaceTextRange(range, fixedText);
 		};
 
@@ -74,14 +74,15 @@ module.exports = {
 				checkNode(
 					node,
 					(stringNode) => stringNode.value,
-					({ start, end }) => [start + 1, end - 1]
+					([start, end]) => [start + 1, end - 1]
 				);
 			},
 			TemplateElement(node) {
 				checkNode(
 					node,
 					(quasi) => quasi.value.raw,
-					({ start, end }) => [start, end]
+					([start, end]) =>
+						node.tail ? [start + 1, end - 1] : [start + 1, end - 2]
 				);
 			},
 		};

eslint-plugin/tests/lib/rules/no-double-dash-modifier.js

@@ -132,6 +132,32 @@ ruleTester.run('no-double-dash-modifier', rule, {
 			],
 			parserOptions,
 		},
+		{
+			code: '<div className={`${otherclasses}slds-dropdown--${position}`}/>',
+			output: '<div className={`${otherclasses}slds-dropdown_${position}`}/>',
+			errors: [
+				{
+					message:
+						'SLDS modifier CSS classes should use a single ' +
+						'underscore instead of double-hyphen: ' +
+						'"slds-dropdown--".',
+				},
+			],
+			parserOptions,
+		},
+		{
+			code: '{[`${otherClases}slds-button__icon--large`]}',
+			output: '{[`${otherClases}slds-button__icon_large`]}',
+			errors: [
+				{
+					message:
+						'SLDS modifier CSS classes should use a single ' +
+						'underscore instead of double-hyphen: ' +
+						'"slds-button__icon--large".',
+				},
+			],
+			parserOptions,
+		},
 	],
 	/* eslint-enable no-template-curly-in-string */
 });