Finished Form class tests

Author: santigarcor

package.json

@@ -5,7 +5,8 @@
   "main": "dist/Form.js",
   "scripts": {
     "test": "node ./node_modules/jest/bin/jest",
-    "build": "node ./node_modules/babel-cli/bin/babel src --out-dir dist"
+    "build": "node ./node_modules/babel-cli/bin/babel src --out-dir dist",
+    "preversion": "npm test"
   },
   "repository": {
     "type": "git",

src/Form.js

@@ -1,10 +1,6 @@
 let FormErrors = require('./FormErrors');
 let RequestDataContainer = require('./RequestDataContainer');
 
-if (window.axios == 'undefined') {
-  let axios = require('axios');
-}
-
 /**
 * this class handles everything that concerns
 * about forms. Submit and errors and considered too
@@ -25,6 +21,12 @@ class Form {
     this.method = method;
     this.clearAfterResponse = clearAfterResponse;
     this.errors = new FormErrors();
+
+    if (window.axios == undefined) {
+      this.axios = require('axios');
+    } else {
+      this.axios = window.axios;
+    }
   }
 
   static makeFrom(data, method = 'post', clearAfterResponse = false) {
@@ -54,10 +56,6 @@ class Form {
       container.set(field, this[field]);
     }
 
-    if (this.method != 'post') {
-      container.set('_method', this.method);
-    }
-
     return container.data;
   }
 
@@ -89,8 +87,14 @@ class Form {
    * @return {Promise}
    */
   submit(url, dataType = 'form_data') {
+    let supportedMethods = ['post', 'put', 'patch'];
+
+    if (supportedMethods.indexOf(this.method.toLowerCase()) == -1) {
+      throw new Error('Unssuported method');
+    }
+
     return new Promise((resolve, reject) => {
-      axios.post(url, this.data(dataType))
+      this.axios[this.method](url, this.data(dataType))
         .then(response => {
           this.formSubmitSucceded(response);
           resolve(response);

tests/form.test.js

@@ -1,7 +1,6 @@
 let Form = require('../src/Form');
 let moxios = require('moxios');
 
-
 test('can create a form with data, method (optional) and clearAfterResponse (optional)', () => {
   let form = Form.makeFrom({name: 'test'}, 'post', false);
 
@@ -62,21 +61,35 @@ test('it retrieves the form data as a FormData', () => {
 });
 
 test('can submit the form and use promises to receive the results', () => {
-  moxios.install();
-  let form = Form.makeFrom({name: 'test', email: 'test@mail.com'});
+  let form = Form.makeFrom({name: 'test', email: 'test@mail.com'}, 'post');
+  moxios.install(form.axios);
 
-  form.submit('theurl')
-    .then(response => {
-      console.log(response);
-      expect(response.data).toEqual('correct');
+  moxios.wait(function () {
+    moxios.requests.mostRecent().respondWith({
+      status: 200,
+      response: 'done'
     });
+  });
+
+  return form.submit('url').then(response => {
+    expect(response.data).toBe("done");
+    moxios.uninstall(form.axios);
+  });
+});
+
+test('can submit the form and use promises to receive the validation errors', () => {
+  let form = Form.makeFrom({name: 'test', email: 'test@mail.com'}, 'post');
+  moxios.install(form.axios);
 
   moxios.wait(function () {
-    let request = moxios.requests.mostRecent()
-    request.respondWith({
-      status: 200,
-      data: "correct"
-    })
-  })
-  moxios.uninstall();
+    moxios.requests.mostRecent().respondWith({
+      status: 422,
+      response: { errors: { name: ['failed'] } }
+    });
+  });
+
+  return form.submit('url').catch(error => {
+    expect(form.errorsFor('name')).toBe("failed");
+    moxios.uninstall(form.axios);
+  });
 });