Skip to content

Commit 45b512c

Browse files
committed
fixes
1 parent c084dc4 commit 45b512c

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

.github/actions/deploy-to-control-plane/action.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ inputs:
1717
description: 'Timeout in seconds for waiting for workloads to be ready'
1818
required: false
1919
default: '900'
20+
cpln_token:
21+
description: 'Control Plane token'
22+
required: true
23+
pr_number:
24+
description: 'Pull Request number'
25+
required: true
2026

2127
outputs:
2228
review_app_url:
@@ -50,11 +56,14 @@ runs:
5056
run: ${{ github.action_path }}/scripts/get-commit-sha.sh
5157
env:
5258
GITHUB_TOKEN: ${{ inputs.github_token }}
53-
PR_NUMBER: ${{ env.PR_NUMBER }}
59+
PR_NUMBER: ${{ inputs.pr_number }}
5460

5561
- name: Deploy to Control Plane
5662
id: deploy
5763
shell: bash
64+
env:
65+
CPLN_TOKEN: ${{ inputs.cpln_token }}
66+
PR_NUMBER: ${{ inputs.pr_number }}
5867
run: |
5968
echo "🚀 Deploying app for PR #${PR_NUMBER}..."
6069

.github/workflows/deploy-to-control-plane.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ jobs:
103103

104104
- name: Check if Review App Exists
105105
id: check-app
106-
if: github.event_name == 'push'
107-
env:
108-
CPLN_TOKEN: ${{ secrets.CPLN_TOKEN }}
109106
run: |
110107
if ! cpflow exists -a ${{ env.APP_NAME }}; then
111108
echo "No review app exists for this PR"
@@ -283,9 +280,8 @@ jobs:
283280
org: ${{ env.CPLN_ORG }}
284281
github_token: ${{ secrets.GITHUB_TOKEN }}
285282
wait_timeout: ${{ vars.WAIT_TIMEOUT || 900 }}
286-
env:
287-
CPLN_TOKEN: ${{ env.CPLN_TOKEN }}
288-
PR_NUMBER: ${{ env.PR_NUMBER }}
283+
cpln_token: ${{ secrets.CPLN_TOKEN_STAGING }}
284+
pr_number: ${{ env.PR_NUMBER }}
289285

290286
- name: Update Status - Deployment Complete
291287
uses: actions/github-script@v7

.github/workflows/help-command.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ jobs:
3030
- name: Checkout
3131
uses: actions/checkout
3232

33-
- name: Show Help Information
34-
uses: shakacode/shared-actions/help-command@justin808-more-work-on-review-apps-2
33+
- name: Process Help Command
34+
uses: shakacode/react-webpack-rails-tutorial/.github/actions/help-command@justin808-more-work-on-review-apps-2
3535
with:
3636
github-token: ${{ secrets.GITHUB_TOKEN }}
37-
issue-number: ${{ github.event.inputs.issue-number }}
37+
issue-number: ${{ github.event.inputs.issue-number }}

0 commit comments

Comments
 (0)