feat: Support RFC 9535 JSON Path syntax and prune dependencies (#11)

Reference: https://pkg.go.dev/github.com/wasilibs/go-re2
Reference: https://spec.openapis.org/arazzo/v1.0.1#criterion-expression-type-object

The first change to remove the `github.com/wasilibs/go-re2` Go module dependency is purely for binary size considerations. It adds 2.49 MB by itself, plus its dependencies, to binary size. As noted by its README:

> Note that if your regular expressions or input are small, this library is slower than the standard library. You will generally "know" if your application requires high performance for complex regular expressions, for example in security filtering software. If you do not know your app has such needs, you should turn away now.

If regular expression parsing speed is a real concern, a separate Go submodule with the swapped dependency might be a better implementation so its opt-in for consumers.

The second change replaces `k8s.io/client-go/util/jsonpath` with `github.com/speakeasy-api/jsonpath`. When this Go module was initially created, RFC 9535 compatible libraries did not exist yet. This change ensures RFC 9535 compliance, which is noted in the Arazzo version 1.0.1 specification as what should be the default when Criterion Expression Type Object (and its `version`) is not specified, which is the most common use case. If handling `version: draft-goessner-dispatch-jsonpath-00` is absolutely required, then a separate feature request should be created for consideration.

Additional test validation ignores are added for legitimate RFC 9535 syntax issues (e.g. those criterion without explicit `version: draft-goessner-dispatch-jsonpath-00`) and the opposite now-unsupported `version: draft-goessner-dispatch-jsonpath-00`.

Author: bflad

arazzo/arazzo_test.go

@@ -480,6 +480,10 @@ var stressTests = []struct {
 		name: "Redocly Museum API",
 		args: args{
 			location: "https://raw.githubusercontent.com/Redocly/museum-openapi-example/2770b2b2e59832d245c7b0eb0badf6568d7efb53/arazzo/museum-api.arazzo.yaml",
+			validationIgnores: []string{
+				"[71:24] invalid jsonpath expression: Error at line 1, column 7: unexpected token when parsing segment",  // legit invalid RFC 9535 syntax
+				"[107:24] invalid jsonpath expression: Error at line 1, column 7: unexpected token when parsing segment", // legit invalid RFC 9535 syntax
+			},
 		},
 		wantTitle: "Redocly Museum API Test Workflow",
 	},
@@ -494,6 +498,9 @@ var stressTests = []struct {
 		name: "Redocly Warp API",
 		args: args{
 			location: "https://raw.githubusercontent.com/Redocly/warp-single-sidebar/b78fc09da52d7755e92e1bc8f990edd37421cbde/apis/arazzo.yaml",
+			validationIgnores: []string{
+				"[63:24] invalid jsonpath expression: Error at line 1, column 12: unexpected token when parsing segment", // legit invalid RFC 9535 syntax
+			},
 		},
 		wantTitle: "Warp API",
 	},
@@ -532,6 +539,12 @@ var stressTests = []struct {
 		name: "Arazzo OAuth Example",
 		args: args{
 			location: "https://raw.githubusercontent.com/OAI/Arazzo-Specification/23852b8b0d13ab1e3288a57a990611ffed45ab5d/examples/1.0.0/oauth.arazzo.yaml",
+			validationIgnores: []string{
+				"[65:24] invalid jsonpath expression: Error at line 1, column 15: unexpected token when parsing segment",  // legit invalid RFC 9535 syntax
+				"[105:24] invalid jsonpath expression: Error at line 1, column 15: unexpected token when parsing segment", // legit invalid RFC 9535 syntax
+				"[155:24] invalid jsonpath expression: Error at line 1, column 15: unexpected token when parsing segment", // legit invalid RFC 9535 syntax
+				"[175:24] invalid jsonpath expression: Error at line 1, column 15: unexpected token when parsing segment", // legit invalid RFC 9535 syntax
+			},
 		},
 		wantTitle: "Example OAuth service",
 	},
@@ -567,7 +580,9 @@ var stressTests = []struct {
 		args: args{
 			location: "https://raw.githubusercontent.com/leidenheit/itarazzo-library/3b335e1c4293444add52b5f2476420e2d871b1a5/src/test/resources/test.arazzo.yaml",
 			validationIgnores: []string{
-				"expression is not valid, must begin with $: <root><id>4711</id><name>Chocolate</name></root>", // legit issue
+				"expression is not valid, must begin with $: <root><id>4711</id><name>Chocolate</name></root>",          // legit issue
+				"[32:24] invalid jsonpath expression: Error at line 1, column 0: unexpected token",                      // unsupported version: draft-goessner-dispatch-jsonpath-00
+				"[36:24] invalid jsonpath expression: Error at line 1, column 5: unexpected token when parsing segment", // unsupported version: draft-goessner-dispatch-jsonpath-00
 			},
 		},
 		wantTitle: "A cookie eating workflow",
@@ -579,6 +594,9 @@ var stressTests = []struct {
 			validationIgnores: []string{
 				"jsonpointer must start with /: $.status", // legit issues TODO: improve the error returned as it is wrong
 				"jsonpointer must start with /: $.id",     // legit issues TODO: improve the error returned as it is wrong
+				"[81:24] invalid jsonpath expression: Error at line 1, column 7: unexpected token when parsing segment",  // unsupported version: draft-goessner-dispatch-jsonpath-00
+				"[110:24] invalid jsonpath expression: Error at line 1, column 5: unexpected token when parsing segment", // unsupported version: draft-goessner-dispatch-jsonpath-00
+				"[114:24] invalid jsonpath expression: Error at line 1, column 9: unexpected token when parsing segment", // unsupported version: draft-goessner-dispatch-jsonpath-00
 			},
 		},
 		wantTitle: "PetStore - Example of Workflows",
@@ -587,6 +605,9 @@ var stressTests = []struct {
 		name: "Ritza build-a-bot workflow",
 		args: args{
 			location: "https://raw.githubusercontent.com/ritza-co/e2e-testing-arazzo/c0615c3708a1e4c0fcaeb79edae78ddc4eb5ba82/arazzo.yaml",
+			validationIgnores: []string{
+				"[42:24] invalid jsonpath expression: Error at line 1, column 8: unexpected token", // legit invalid RFC 9535 syntax
+			},
 		},
 		wantTitle: "Build-a-Bot Workflow",
 	},

arazzo/criterion/criterion.go

@@ -3,15 +3,15 @@ package criterion
 import (
 	"context"
 	"fmt"
+	"regexp"
 	"strings"
 
+	"github.com/speakeasy-api/jsonpath/pkg/jsonpath"
 	"github.com/speakeasy-api/openapi/arazzo/core"
 	"github.com/speakeasy-api/openapi/arazzo/expression"
 	"github.com/speakeasy-api/openapi/extensions"
 	"github.com/speakeasy-api/openapi/marshaller"
 	"github.com/speakeasy-api/openapi/validation"
-	regexp "github.com/wasilibs/go-re2"
-	"k8s.io/client-go/util/jsonpath"
 )
 
 // CriterionType represents the type of criterion.
@@ -297,7 +297,7 @@ func (c *Criterion) validateCondition(opts ...validation.Option) []error {
 			})
 		}
 	case CriterionTypeJsonPath:
-		if err := jsonpath.NewParser("jsonpath").Parse(c.Condition); err != nil {
+		if _, err := jsonpath.NewPath(c.Condition); err != nil {
 			errs = append(errs, &validation.Error{
 				Message: fmt.Errorf("invalid jsonpath expression: %w", err).Error(),
 				Line:    conditionLine,

go.mod

@@ -4,17 +4,14 @@ go 1.23
 
 require (
 	github.com/santhosh-tekuri/jsonschema/v6 v6.0.1
+	github.com/speakeasy-api/jsonpath v0.6.1
 	github.com/stretchr/testify v1.9.0
-	github.com/wasilibs/go-re2 v1.7.0
 	gopkg.in/yaml.v3 v3.0.1
-	k8s.io/client-go v0.31.1
 )
 
 require (
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
+	github.com/kr/text v0.2.0 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
-	github.com/tetratelabs/wazero v1.8.0 // indirect
-	github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52 // indirect
-	golang.org/x/sys v0.21.0 // indirect
 	golang.org/x/text v0.18.0 // indirect
 )

go.sum

@@ -1,30 +1,24 @@
+github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
 github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/dlclark/regexp2 v1.11.0 h1:G/nrcoOa7ZXlpoa/91N3X7mM3r8eIlMBBJZvsz/mxKI=
 github.com/dlclark/regexp2 v1.11.0/go.mod h1:DHkYz0B9wPfa6wondMfaivmHpzrQ3v9q8cnmRbL6yW8=
-github.com/magefile/mage v1.15.1-0.20230912152418-9f54e0f83e2a h1:tdPcGgyiH0K+SbsJBBm2oPyEIOTAvLBwD9TuUwVtZho=
-github.com/magefile/mage v1.15.1-0.20230912152418-9f54e0f83e2a/go.mod h1:z5UZb/iS3GoOSn0JgWuiw7dxlurVYTu+/jHXqQg881A=
+github.com/kr/pretty v0.1.0 h1:L/CwN0zerZDmRFUapSPitk6f+Q3+0za1rQkzVuMiMFI=
+github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo=
+github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
+github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
 github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
 github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/santhosh-tekuri/jsonschema/v6 v6.0.1 h1:PKK9DyHxif4LZo+uQSgXNqs0jj5+xZwwfKHgph2lxBw=
 github.com/santhosh-tekuri/jsonschema/v6 v6.0.1/go.mod h1:JXeL+ps8p7/KNMjDQk3TCwPpBy0wYklyWTfbkIzdIFU=
+github.com/speakeasy-api/jsonpath v0.6.1 h1:FWbuCEPGaJTVB60NZg2orcYHGZlelbNJAcIk/JGnZvo=
+github.com/speakeasy-api/jsonpath v0.6.1/go.mod h1:ymb2iSkyOycmzKwbEAYPJV/yi2rSmvBCLZJcyD+VVWw=
 github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
 github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
-github.com/tetratelabs/wazero v1.8.0 h1:iEKu0d4c2Pd+QSRieYbnQC9yiFlMS9D+Jr0LsRmcF4g=
-github.com/tetratelabs/wazero v1.8.0/go.mod h1:yAI0XTsMBhREkM/YDAK/zNou3GoiAce1P6+rp/wQhjs=
-github.com/wasilibs/go-re2 v1.7.0 h1:bYhl8gn+a9h01dxwotNycxkiFPTiSgwUrIz8KZJ90Lc=
-github.com/wasilibs/go-re2 v1.7.0/go.mod h1:sUsZMLflgl+LNivDE229omtmvjICmOseT9xOy199VDU=
-github.com/wasilibs/nottinygc v0.4.0 h1:h1TJMihMC4neN6Zq+WKpLxgd9xCFMw7O9ETLwY2exJQ=
-github.com/wasilibs/nottinygc v0.4.0/go.mod h1:oDcIotskuYNMpqMF23l7Z8uzD4TC0WXHK8jetlB3HIo=
-github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52 h1:OvLBa8SqJnZ6P+mjlzc2K7PM22rRUPE1x32G9DTPrC4=
-github.com/wasilibs/wazero-helpers v0.0.0-20240620070341-3dff1577cd52/go.mod h1:jMeV4Vpbi8osrE/pKUxRZkVaA0EX7NZN0A9/oRzgpgY=
-golang.org/x/sys v0.21.0 h1:rF+pYz3DAGSQAxAu1CbC7catZg4ebC4UIeIhKxBZvws=
-golang.org/x/sys v0.21.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/text v0.18.0 h1:XvMDiNzPAl0jr17s6W9lcaIhGUfUORdGCNsuLmPG224=
 golang.org/x/text v0.18.0/go.mod h1:BuEKDfySbSR4drPmRPG/7iBdf8hvFMuRexcpahXilzY=
-gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
+gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 h1:YR8cESwS4TdDjEe65xsg0ogRM/Nc3DYOhEAlW+xobZo=
+gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
-k8s.io/client-go v0.31.1 h1:f0ugtWSbWpxHR7sjVpQwuvw9a3ZKLXX0u0itkFXufb0=
-k8s.io/client-go v0.31.1/go.mod h1:sKI8871MJN2OyeqRlmA4W4KM9KBdBUpDLu/43eGemCg=