@@ -89,7 +89,7 @@ void shouldFailWhenControllerAdviceNull() {
89
89
90
90
@ Test
91
91
void equalsHashCodeAndToString () {
92
- String beanName = getSingletonBeanName ( SimpleControllerAdvice .class );
92
+ String beanName = SimpleControllerAdvice .class . getSimpleName ( );
93
93
ControllerAdviceBean bean1 = createSingletonControllerAdviceBean (SimpleControllerAdvice .class );
94
94
ControllerAdviceBean bean2 = createSingletonControllerAdviceBean (SimpleControllerAdvice .class );
95
95
assertEqualsHashCodeAndToString (bean1 , bean2 , beanName );
@@ -113,16 +113,17 @@ void orderedViaAnnotation() {
113
113
114
114
@ Test
115
115
void resolveBeanForSingletonBean () {
116
+ String beanName = SimpleControllerAdvice .class .getSimpleName ();
116
117
ControllerAdviceBean cab = createSingletonControllerAdviceBean (SimpleControllerAdvice .class );
117
- Object bean = this .applicationContext .getBean (getSingletonBeanName ( SimpleControllerAdvice . class ) );
118
+ Object bean = this .applicationContext .getBean (beanName );
118
119
assertThat (cab ).extracting ("resolvedBean" ).isNull ();
119
120
Object resolvedBean = cab .resolveBean ();
120
121
assertThat (cab ).extracting ("resolvedBean" ).isEqualTo (bean );
121
122
assertThat (resolvedBean ).isEqualTo (bean );
122
123
}
123
124
124
125
@ Test
125
- void resolveBeanForNonSingletonBean () {
126
+ void resolveBeanForPrototypeBean () {
126
127
ControllerAdviceBean cab = createPrototypeControllerAdviceBean (SimpleControllerAdvice .class );
127
128
assertThat (cab ).extracting ("resolvedBean" ).isNull ();
128
129
Object resolvedBean = cab .resolveBean ();
@@ -220,27 +221,19 @@ public void findAnnotatedBeansSortsBeans() {
220
221
}
221
222
222
223
private ControllerAdviceBean createSingletonControllerAdviceBean (Class <?> beanType ) {
223
- String beanName = getSingletonBeanName ( beanType );
224
+ String beanName = beanType . getSimpleName ( );
224
225
this .applicationContext .registerSingleton (beanName , beanType );
225
226
ControllerAdvice controllerAdvice = AnnotatedElementUtils .findMergedAnnotation (beanType , ControllerAdvice .class );
226
227
return new ControllerAdviceBean (beanName , this .applicationContext , controllerAdvice );
227
228
}
228
229
229
- private static String getSingletonBeanName (Class <?> beanType ) {
230
- return beanType .getSimpleName () + "Singleton" ;
231
- }
232
-
233
230
private ControllerAdviceBean createPrototypeControllerAdviceBean (Class <?> beanType ) {
234
- String beanName = getPrototypeBeanName ( beanType );
231
+ String beanName = beanType . getSimpleName ( );
235
232
this .applicationContext .registerPrototype (beanName , beanType );
236
233
ControllerAdvice controllerAdvice = AnnotatedElementUtils .findMergedAnnotation (beanType , ControllerAdvice .class );
237
234
return new ControllerAdviceBean (beanName , this .applicationContext , controllerAdvice );
238
235
}
239
236
240
- private static String getPrototypeBeanName (Class <?> beanType ) {
241
- return beanType .getSimpleName () + "Prototype" ;
242
- }
243
-
244
237
private void assertEqualsHashCodeAndToString (ControllerAdviceBean bean1 , ControllerAdviceBean bean2 , String toString ) {
245
238
assertThat (bean1 ).isEqualTo (bean2 );
246
239
assertThat (bean2 ).isEqualTo (bean1 );
0 commit comments