Skip to content

Commit d8aa1ea

Browse files
committed
fix typeDefs and fragments, better naming, decluttering
1 parent b689eac commit d8aa1ea

File tree

5 files changed

+28
-7
lines changed

5 files changed

+28
-7
lines changed

api/typeDefs/item.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ export default gql`
105105
uploadId: Int
106106
pollCost: Int
107107
deletedAt: Date
108+
originalItemId: Int
108109
}
109110
110111
type Comments {

components/item-history.js

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,21 @@ export function OldItem ({ version }) {
1919
)
2020
}
2121

22-
export default function HistoryDropdownItem ({ item }) {
22+
export default function HistoryDropdown ({ item }) {
2323
const router = useRouter()
2424
const showModal = useShowModal()
2525

26+
const lastEdited = new Date(item.oldVersions[0].cloneDiedAt)
27+
28+
// TODO: overengineering? not handling it just closes the modal
29+
/* const handleLastEdit = () => {
30+
if (!item.parentId) {
31+
router.replace(`/items/${item.id}`)
32+
} else {
33+
router.replace(`/items/${item.parentId}/?commentId=${item.id}`)
34+
}
35+
} */
36+
2637
return (
2738
<Dropdown className='pointer' as='span'>
2839
<Dropdown.Toggle as='span' onPointerDown={e => e.preventDefault()}>
@@ -33,11 +44,18 @@ export default function HistoryDropdownItem ({ item }) {
3344
edited {item.oldVersions.length} times
3445
</Dropdown.Header>
3546
<hr className='dropdown-divider' />
36-
<Dropdown.Item title={item.oldVersions[0].cloneDiedAt} onClick={() => router.push(`/items/${item.id}`)}>
37-
edited {timeSince(new Date(item.oldVersions[0].cloneDiedAt))} ago (most recent)
47+
<Dropdown.Item
48+
title={lastEdited}
49+
// onClick={handleLastEdit}
50+
>
51+
edited {timeSince(lastEdited)} ago (most recent)
3852
</Dropdown.Item>
39-
{item.oldVersions.map((version) => ( // TODO: prettier
40-
<Dropdown.Item key={version.id} title={version.cloneBornAt} onClick={() => showModal((onClose) => <OldItem version={version} onClose={onClose} />)}>
53+
{item.oldVersions.map((version) => (
54+
<Dropdown.Item
55+
key={version.id}
56+
title={version.cloneBornAt}
57+
onClick={() => showModal((onClose) => <OldItem version={version} onClose={onClose} />)}
58+
>
4159
{!version.cloneBornAt ? 'created' : 'edited'} {timeSince(new Date(version.cloneBornAt || version.createdAt))} ago
4260
</Dropdown.Item>
4361
))}

components/item-info.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { useShowModal } from './modal'
2929
import classNames from 'classnames'
3030
import SubPopover from './sub-popover'
3131
import useCanShadowEdit from './use-can-edit'
32-
import HistoryDropdownItem from './item-history'
32+
import HistoryDropdown from './item-history'
3333

3434
function itemTitle (item) {
3535
let title = ''
@@ -149,7 +149,7 @@ export default function ItemInfo ({
149149
{item.oldVersions?.length > 0 && !item.deletedAt &&
150150
<>
151151
<span> </span>
152-
<HistoryDropdownItem item={item} />
152+
<HistoryDropdown item={item} />
153153
</>}
154154
</span>
155155
{item.subName &&

fragments/comments.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ export const COMMENT_FIELDS = gql`
6565
uploadId
6666
pollCost
6767
deletedAt
68+
originalItemId
6869
}
6970
rel
7071
apiKey

fragments/items.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ export const ITEM_FIELDS = gql`
9090
uploadId
9191
pollCost
9292
deletedAt
93+
originalItemId
9394
}
9495
rel
9596
apiKey

0 commit comments

Comments
 (0)