Catch 500 error better

Author: technicalguru

index-example.php

@@ -15,7 +15,7 @@
 	echo '<h1>Internal Error</h1>';
 	echo '<p>Cannot create application.</p>';
 	if ($DEBUG) {
-		echo '<pre>'.$e->getMessage()."\n".$e->getTraceAsString().'</pre>';
+		echo('<pre>'.\TgUtils\FormatUtils::getTraceAsString($e).'</pre>');
 	}
 }
 

src/WebApp/Error/Error500.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace WebApp\Error;
+
+class Error500 extends \WebApp\Page {
+
+	public function __construct($app, $throwable = NULL) {
+		parent::__construct($app);
+		$this->throwable = $throwable;
+	}
+
+	public function getTitle() {
+		return 'page500_title';
+	}
+
+	public function getMain() {
+		header('HTTP/1.1 500 Internal Error');
+		$rc = new \WebApp\Component\MainContent($this);
+		new \WebApp\Component\Title($rc, 'page500_title');
+		new \WebApp\Component\Subtitle($rc, 'page500_subtitle');
+		$p = new \WebApp\Component\Paragraph($rc, 'page500_description');
+		$p->addClass('small');
+		if (($this->throwable != NULL) && ($DEBUG || ($this->app->config->has('debug') && $this->app->config->get('debug')))) {
+			$rc->addChild('<pre>'.\TgUtils\FormatUtils::getTraceAsString($this->throwable).'</pre>');
+		}
+		return $rc;
+	}
+}
+

src/WebApp/Service.php

@@ -17,51 +17,64 @@ public function __construct() {
 	}
 
 	public function run() {
-		// Process the request first
-		$rc     = $this->page->processRequest();
-		$action = is_array($rc) ? $rc[0] : $rc;
-
-		// Render when required
-		if ($action == 'render') {
-			Log::debug('$_SERVER=', $_SERVER);
-			Log::debug('Request=', $this->app->request);
-			$this->theme->render($this->page);
-			Session\Utils::isFreshLogin();
-		} else if ($action == 'redirect') {
-			// redirect
-			$this->app->afterRequest();
-			header('Location: '.$rc[1]);
+		try {
+			// Process the request first
+			$rc     = $this->page->processRequest();
+			$action = is_array($rc) ? $rc[0] : $rc;
+
+			// Render when required
+			if ($action == 'render') {
+				Log::debug('$_SERVER=', $_SERVER);
+				Log::debug('Request=', $this->app->request);
+				$this->theme->render($this->page);
+				Session\Utils::isFreshLogin();
+			} else if ($action == 'redirect') {
+				// redirect
+				$this->app->afterRequest();
+				header('Location: '.$rc[1]);
+			}
+		} catch (\Throwable $e) {
+			\TgLog\Log::error('Cannot create application', $e);
+			$page = new Error\Error500($this->app, $e);
+			$page->processRequest();
+			$this->theme->render($page);
 		}
+
 		$this->app->afterRequest();
 	}
 
 
 	protected function createPage() {
-		$request = $this->app->request;
-
-		// Check the path info
-		$canonical = $this->app->router->getCanonicalPath();
-		$requested = $request->originalPath;
-		if ($requested != $canonical) {
-			$params  = $request->params;
-			if ($params) $params = '?'.$params;
-			header('Location: '.$canonical.$params);
-			exit;
-		}
-
-		// Try to find the correct page
-		$page  = $this->app->router->getPage();
-
-		// Get a specific error page from the theme
-		if ($page == NULL) {
-			$page = $this->theme->getErrorPage(404);
-		}
-
-		// Get the default error page
-		if ($page == NULL) {
-			$page = new Error\Error404($this->app);
+		try {
+			$request = $this->app->request;
+
+			// Check the path info
+			$canonical = $this->app->router->getCanonicalPath();
+			$requested = $request->originalPath;
+			if ($requested != $canonical) {
+				$params  = $request->params;
+				if ($params) $params = '?'.$params;
+				header('Location: '.$canonical.$params);
+				exit;
+			}
+
+			// Try to find the correct page
+			$page  = $this->app->router->getPage();
+
+			// Get a specific error page from the theme
+			if ($page == NULL) {
+				$page = $this->theme->getErrorPage(404);
+			}
+
+			// Get the default error page
+			if ($page == NULL) {
+				$page = new Error\Error404($this->app);
+			}
+			return $page;
+		} catch (\Throwable $e) {
+			\TgLog\Log::error('Cannot create application', $e);
+			return new Error\Error500($this->app, $e);
 		}
-		return $page;
 	}
 
 	protected function createApp() {

src/i18n.php

@@ -141,6 +141,18 @@
 		'de' => 'Diese Seite existiert nicht oder es ist etwas Schreckliches passiert.',
 		'en' => 'This page doesn\'t exist or something terrible happened.',
 	),
+	'page500_title' => array(
+		'de' => 'Na toll!',
+		'en' => 'Oh great!',
+	),
+	'page500_subtitle' => array(
+		'de' => 'Jetzt habt Ihr die Seite kaputt gemacht.',
+		'en' => 'You destroyed the page now.',
+	),
+	'page500_description' => array(
+		'de' => 'Es ist etwas Schreckliches passiert.',
+		'en' => 'Something terrible happened.',
+	),
 	'first_page_label' => array(
 		'de' => '<i class="fas fa-step-backward"></i>',
 		'en' => '<i class="fas fa-step-backward"></i>',