Skip to content

[Feature Request] Add counter metric for unaccessed failed promises #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsurdilo opened this issue May 27, 2025 · 0 comments
Open

[Feature Request] Add counter metric for unaccessed failed promises #2538

tsurdilo opened this issue May 27, 2025 · 0 comments
Labels
enhancement User experience

Comments

@tsurdilo
Copy link
Contributor

tsurdilo commented May 27, 2025

https://github.com/temporalio/sdk-java/blob/master/temporal-sdk/src/main/java/io/temporal/internal/sync/DeterministicRunnerImpl.java#L336-L347

Would be useful to have a counter metric for this. Would allow detection so can fix in code if was oversight not to wait on promise,or ignore warning via something like

promise.exceptionally(e->null);
or promise.handle((ex, failure) -> null);

@tsurdilo tsurdilo added the enhancement User experience label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User experience
Projects
None yet
Development

No branches or pull requests

1 participant