Skip to content

Commit e6379eb

Browse files
committed
renaming notebook to notebooks
1 parent 2eb857f commit e6379eb

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ Job creator has `IS_OWNER` permission. Destroying databricks_permissions resourc
179179
- Jobs triggered through Run Now assume the permissions of the job owner and not the user, and service principal who issued Run Now.
180180

181181
```
182-
job_access_control = [
182+
jobs_access_control = [
183183
{
184184
group_name = "<group_name>"
185185
permission_level = "CAN_MANAGE_RUN"
@@ -210,7 +210,7 @@ Put notebooks in notebooks folder and provide below information:
210210
Notebook can have one of these permissions: `CAN_READ`, `CAN_RUN`, `CAN_EDIT`, and `CAN_MANAGE`.
211211

212212
```
213-
notebook_access_control = [
213+
notebooks_access_control = [
214214
{
215215
group_name = "<group_name>"
216216
permission_level = "CAN_MANAGE"
@@ -424,7 +424,7 @@ No modules.
424424
| <a name="input_min_memory_gb"></a> [min\_memory\_gb](#input\_min\_memory\_gb) | Minimum amount of memory per node in gigabytes. Defaults to 0. | `string` | `0` | no |
425425
| <a name="input_min_retry_interval_millis"></a> [min\_retry\_interval\_millis](#input\_min\_retry\_interval\_millis) | An optional minimal interval in milliseconds between the start of the failed run and the subsequent retry run. The default behavior is that unsuccessful runs are immediately retried. | `number` | `null` | no |
426426
| <a name="input_ml"></a> [ml](#input\_ml) | ML required or not. | `bool` | `false` | no |
427-
| <a name="input_notebook_access_control"></a> [notebook\_access\_control](#input\_notebook\_access\_control) | Notebook access control | `any` | `null` | no |
427+
| <a name="input_notebooks_access_control"></a> [notebook\_access\_control](#input\_notebook\_access\_control) | Notebook access control | `any` | `null` | no |
428428
| <a name="input_notebooks"></a> [notebooks](#input\_notebooks) | nested block: NestingSet, min items: 0, max items: 0 | `any` | `[]` | no |
429429
| <a name="input_num_workers"></a> [num\_workers](#input\_num\_workers) | number of workers for job | `number` | `1` | no |
430430
| <a name="input_policy_access_control"></a> [policy\_access\_control](#input\_policy\_access\_control) | Policy access control | `any` | `null` | no |

examples/jobs/1_job_on_new_cluster_with_new_and_existing_notebooks/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ module "databricks_workspace_management" {
7777
# ------------------------------------------------
7878
# NOTEBOOK ACCESS CONTROL
7979
# ------------------------------------------------
80-
notebook_access_control = [
80+
notebooks_access_control = [
8181
{
8282
group_name = "demo"
8383
permission_level = "CAN_READ"

examples/jobs/2_job_on_existing_cluster_with_new_notebooks/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ module "databricks_workspace_management" {
7171
# ------------------------------------------------
7272
# NOTEBOOK ACCESS CONTROL
7373
# ------------------------------------------------
74-
notebook_access_control = [
74+
notebooks_access_control = [
7575
{
7676
group_name = "demo"
7777
permission_level = "CAN_READ"

examples/notebooks/1_deploy_notebooks/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module "databricks_workspace_management" {
3636
# ------------------------------------------------
3737
# NOTEBOOK ACCESS CONTROL
3838
# ------------------------------------------------
39-
notebook_access_control = [
39+
notebooks_access_control = [
4040
{
4141
group_name = "demo"
4242
permission_level = "CAN_READ"

permissions.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ resource "databricks_permissions" "existing_cluster_new_job_existing_notebooks"
132132
# Notebooks Permissions
133133
# ------------------------------------------------
134134
resource "databricks_permissions" "notebook" {
135-
for_each = var.notebook_access_control != null ? { for p in var.notebooks : "${p.name}-${p.local_path}" => p } : {}
135+
for_each = var.notebooks_access_control != null ? { for p in var.notebooks : "${p.name}-${p.local_path}" => p } : {}
136136

137137
notebook_path = lookup(each.value, "path", "${data.databricks_current_user.me.home}/${each.value.name}")
138138

139139
dynamic "access_control" {
140-
for_each = var.notebook_access_control != null ? var.notebook_access_control : []
140+
for_each = var.notebooks_access_control != null ? var.notebooks_access_control : []
141141
content {
142142
group_name = access_control.value.group_name
143143
permission_level = access_control.value.permission_level
@@ -146,12 +146,12 @@ resource "databricks_permissions" "notebook" {
146146
}
147147

148148
resource "databricks_permissions" "jobs_notebook" {
149-
for_each = (var.deploy_jobs != false && var.notebook_access_control != null) ? { for p in var.local_notebooks : "${p.job_name}-${p.local_path}" => p } : {}
149+
for_each = (var.deploy_jobs != false && var.notebooks_access_control != null) ? { for p in var.local_notebooks : "${p.job_name}-${p.local_path}" => p } : {}
150150

151151
notebook_path = lookup(each.value, "path", "${data.databricks_current_user.me.home}/${each.value.job_name}")
152152

153153
dynamic "access_control" {
154-
for_each = var.notebook_access_control != null ? var.notebook_access_control : []
154+
for_each = var.notebooks_access_control != null ? var.notebooks_access_control : []
155155
content {
156156
group_name = access_control.value.group_name
157157
permission_level = access_control.value.permission_level

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ variable "jobs_access_control" {
392392
default = null
393393
}
394394

395-
variable "notebook_access_control" {
395+
variable "notebooks_access_control" {
396396
type = any
397397
description = "Notebook access control"
398398
default = null

0 commit comments

Comments
 (0)