Skip to content

Commit 4af08f9

Browse files
committed
- update get error code for event ad load fail
1 parent 06f821f commit 4af08f9

16 files changed

+21
-20
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323

2424
### Add the line below to `Packages/manifest.json`
2525

26-
for version `1.1.6`
26+
for version `1.1.7`
2727
```json
28-
"com.wolf-org.advertising":"https://github.com/unity-package/advertising-unity.git#1.1.6",
28+
"com.wolf-org.advertising":"https://github.com/unity-package/advertising-unity.git#1.1.7",
2929
```
3030
dependency `extensions-unity-1.0.5`
3131
```json

Runtime/Admob/AdmobAppOpenAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ private void OnAdLoaded()
147147
private void OnAdFailedToLoad(LoadAdError error)
148148
{
149149
Common.CallActionAndClean(ref failedToLoadCallback);
150-
OnFailedToLoadAdEvent?.Invoke(error.GetMessage());
150+
OnFailedToLoadAdEvent?.Invoke(error.GetCode().ToString(), error.GetMessage());
151151
}
152152
#endif
153153

Runtime/Admob/AdmobBannerAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ private void OnAdLoaded()
204204
private void OnAdFailedToLoad(LoadAdError error)
205205
{
206206
Common.CallActionAndClean(ref failedToLoadCallback);
207-
OnFailedToLoadAdEvent?.Invoke(error.GetMessage());
207+
OnFailedToLoadAdEvent?.Invoke(error.GetCode().ToString(), error.GetMessage());
208208
if (_reload != null) App.StopCoroutine(_reload);
209209
_reload = DelayBannerReload();
210210
App.StartCoroutine(_reload);

Runtime/Admob/AdmobInterstitialAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ private void OnAdLoaded()
143143
private void OnAdFailedToLoad(LoadAdError error)
144144
{
145145
Common.CallActionAndClean(ref failedToLoadCallback);
146-
OnFailedToLoadAdEvent?.Invoke(error.GetMessage());
146+
OnFailedToLoadAdEvent?.Invoke(error.GetCode().ToString(), error.GetMessage());
147147
}
148148
#endif
149149

Runtime/Admob/AdmobNativeOverlayAdUnit.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ public void RenderAd(RectTransform uiElement, Camera camera, bool useSizeUiEleme
164164
(int admobX, int admobY) = ConvertUiElementPosToNativeAdsPos(uiElement, camera);
165165
if (useSizeUiElement)
166166
{
167-
_nativeOverlayAd?.RenderTemplate(Style(), new AdSize((int)uiElement.rect.width, (int)uiElement.rect.height), admobX, admobY);
167+
_nativeOverlayAd?.RenderTemplate(Style(),
168+
new AdSize((int)uiElement.rect.width, (int)uiElement.rect.height), admobX, admobY);
168169
}
169170
else
170171
{
@@ -338,7 +339,7 @@ private void OnAdPaided(AdValue value)
338339
private void OnAdFailedToLoad(LoadAdError error)
339340
{
340341
Common.CallActionAndClean(ref failedToLoadCallback);
341-
OnFailedToLoadAdEvent?.Invoke(error.GetMessage());
342+
OnFailedToLoadAdEvent?.Invoke(error.GetCode().ToString(), error.GetMessage());
342343
if (_reload != null) App.StopCoroutine(_reload);
343344
_reload = DelayReload();
344345
App.StartCoroutine(_reload);

Runtime/Admob/AdmobRewardAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ private void OnAdLoaded()
153153
private void OnAdFailedToLoad(LoadAdError error)
154154
{
155155
Common.CallActionAndClean(ref failedToLoadCallback);
156-
OnFailedToLoadAdEvent?.Invoke(error.GetMessage());
156+
OnFailedToLoadAdEvent?.Invoke(error.GetCode().ToString(), error.GetMessage());
157157
}
158158

159159
private void UserRewardEarnedCallback(Reward reward)

Runtime/Admob/AdmobRewardedInterstitialAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ private void OnAdClicked()
110110
private void OnAdFailedToLoad(LoadAdError error)
111111
{
112112
Common.CallActionAndClean(ref failedToLoadCallback);
113-
OnFailedToLoadAdEvent?.Invoke(error.GetMessage());
113+
OnFailedToLoadAdEvent?.Invoke(error.GetCode().ToString(), error.GetMessage());
114114
}
115115

116116
private void OnAdLoaded()

Runtime/General/AdUnit.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ namespace VirtueSky.Ads
66
[Serializable]
77
public abstract class AdUnit
88
{
9-
109
[SerializeField] protected string androidId;
1110
[SerializeField] protected string iOSId;
1211

@@ -20,7 +19,7 @@ public abstract class AdUnit
2019
[NonSerialized] public Action<double, string, string, string, string> paidedCallback;
2120

2221
public Action OnLoadAdEvent;
23-
public Action<string> OnFailedToLoadAdEvent;
22+
public Action<string, string> OnFailedToLoadAdEvent;
2423
public Action OnDisplayedAdEvent;
2524
public Action<string> OnFailedToDisplayAdEvent;
2625
public Action OnClosedAdEvent;

Runtime/IronSource/IronSourceBannerAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ void BannerOnAdLoadedEvent(IronSourceAdInfo adInfo)
139139
void BannerOnAdLoadFailedEvent(IronSourceError ironSourceError)
140140
{
141141
Common.CallActionAndClean(ref failedToLoadCallback);
142-
OnFailedToLoadAdEvent?.Invoke(ironSourceError.ToString());
142+
OnFailedToLoadAdEvent?.Invoke(ironSourceError.getCode().ToString(),ironSourceError.getDescription());
143143
Destroy();
144144
}
145145

Runtime/IronSource/IronSourceInterstitialAdUnit.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ void InterstitialOnAdReadyEvent(IronSourceAdInfo adInfo)
7777
void InterstitialOnAdLoadFailed(IronSourceError ironSourceError)
7878
{
7979
Common.CallActionAndClean(ref failedToLoadCallback);
80-
OnFailedToLoadAdEvent?.Invoke(ironSourceError.ToString());
80+
OnFailedToLoadAdEvent?.Invoke(ironSourceError.getCode().ToString(),ironSourceError.getDescription());
81+
8182
}
8283

8384
void InterstitialOnAdOpenedEvent(IronSourceAdInfo adInfo)

Runtime/IronSource/IronSourceRewardAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ void OnAdLoaded()
8282
private void RewardedVideoOnAdLoadFailedEvent(IronSourceError ironSourceError)
8383
{
8484
Common.CallActionAndClean(ref failedToLoadCallback);
85-
OnFailedToLoadAdEvent?.Invoke(ironSourceError.ToString());
85+
OnFailedToLoadAdEvent?.Invoke(ironSourceError.getCode().ToString(), ironSourceError.getDescription());
8686
}
8787

8888
void RewardedVideoOnAdOpenedEvent(IronSourceAdInfo adInfo)

Runtime/Max/MaxAppOpenAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ private void OnAdRevenuePaid(string unit, MaxSdkBase.AdInfo info)
7676
private void OnAdLoadFailed(string unit, MaxSdkBase.ErrorInfo info)
7777
{
7878
Common.CallActionAndClean(ref failedToLoadCallback);
79-
OnFailedToLoadAdEvent?.Invoke(info.Message);
79+
OnFailedToLoadAdEvent?.Invoke(info.Code.ToString(), info.Message);
8080
}
8181

8282
private void OnAdClicked(string arg1, MaxSdkBase.AdInfo arg2)

Runtime/Max/MaxBannerAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ private void OnAdExpanded(string unit, MaxSdkBase.AdInfo info)
145145
private void OnAdLoadFailed(string unit, MaxSdkBase.ErrorInfo info)
146146
{
147147
Common.CallActionAndClean(ref failedToLoadCallback);
148-
OnFailedToLoadAdEvent?.Invoke(info.Message);
148+
OnFailedToLoadAdEvent?.Invoke(info.Code.ToString(), info.Message);
149149
Destroy();
150150
}
151151

Runtime/Max/MaxInterstitialAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ private void OnAdRevenuePaid(string unit, MaxSdkBase.AdInfo info)
102102
private void OnAdLoadFailed(string unit, MaxSdkBase.ErrorInfo info)
103103
{
104104
Common.CallActionAndClean(ref failedToLoadCallback);
105-
OnFailedToLoadAdEvent?.Invoke(info.Message);
105+
OnFailedToLoadAdEvent?.Invoke(info.Code.ToString(), info.Message);
106106
}
107107

108108
private void OnAdLoaded(string unit, MaxSdkBase.AdInfo info)

Runtime/Max/MaxRewardAdUnit.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private void OnAdRevenuePaid(string unit, MaxSdkBase.AdInfo info)
9292
private void OnAdLoadFailed(string unit, MaxSdkBase.ErrorInfo info)
9393
{
9494
Common.CallActionAndClean(ref failedToLoadCallback);
95-
OnFailedToLoadAdEvent?.Invoke(info.Message);
95+
OnFailedToLoadAdEvent?.Invoke(info.Code.ToString(), info.Message);
9696
}
9797

9898
private void OnAdClicked(string arg1, MaxSdkBase.AdInfo arg2)

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"name": "com.wolf-org.advertising",
33
"displayName": "UnityCommon-ADS",
44
"description": "Support show ads for game unity",
5-
"version": "1.1.6",
6-
"unity": "2021.3",
5+
"version": "1.1.7",
6+
"unity": "2022.3",
77
"category": "virtuesky",
88
"license": "MIT",
99
"author": {

0 commit comments

Comments
 (0)