Skip to content

Commit cc8b776

Browse files
authored
Make port state override return failure more for URLPattern
In particular for inputs that do not start with an ASCII digit. Tests: web-platform-tests/wpt#51505. Fixes whatwg/urlpattern#266.
1 parent c23aec1 commit cc8b776

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

url.bs

+11-5
Original file line numberDiff line numberDiff line change
@@ -2613,16 +2613,16 @@ and then runs these steps:
26132613
<p>Otherwise, if one of the following is true:
26142614

26152615
<ul class=brief>
2616-
<li><p><a>c</a> is the <a>EOF code point</a>, U+002F (/), U+003F (?), or U+0023 (#)
2617-
<li><p><var>url</var> <a>is special</a> and <a>c</a> is U+005C (\)
2618-
<li><p><var>state override</var> is given
2616+
<li><p><a>c</a> is the <a>EOF code point</a>, U+002F (/), U+003F (?), or U+0023 (#);
2617+
<li><p><var>url</var> <a>is special</a> and <a>c</a> is U+005C (\); or
2618+
<li><p><var>state override</var> is given,
26192619
</ul>
26202620

26212621
<p>then:
26222622

26232623
<ol>
26242624
<li>
2625-
<p>If <var>buffer</var> is not the empty string, then:
2625+
<p>If <var>buffer</var> is not the empty string:
26262626

26272627
<ol>
26282628
<li><p>Let <var>port</var> be the mathematical integer value that is represented
@@ -2636,9 +2636,14 @@ and then runs these steps:
26362636
<var>url</var>'s <a for=url>scheme</a>'s <a>default port</a>; otherwise to <var>port</var>.
26372637

26382638
<li><p>Set <var>buffer</var> to the empty string.
2639+
2640+
<li><p>If <var>state override</var> is given, then return.
2641+
<!-- API validation error: we'd have to check what c is at this point if we cared about
2642+
this. In particular when it's not EOF it's a bit dodgy. -->
26392643
</ol>
26402644

2641-
<li><p>If <var>state override</var> is given, then return.
2645+
<li><p>If <var>state override</var> is given, then return failure.
2646+
<!-- API validation error -->
26422647

26432648
<li><p>Set <var>state</var> to <a>path start state</a> and decrease <var>pointer</var> by 1.
26442649
</ol>
@@ -4188,6 +4193,7 @@ Sam Ruby,
41884193
Sam Sneddon,
41894194
Santiago M. Mola,
41904195
Sebastian Mayr,
4196+
Shannon Booth,<!-- shannonbooth; GitHub -->
41914197
Simon Pieters,
41924198
Simon Sapin,
41934199
Steven Vachon,

0 commit comments

Comments
 (0)