Skip to content

Commit bca0406

Browse files
committed
Update default branch to trunk
1 parent 39d7fdd commit bca0406

File tree

6 files changed

+18
-17
lines changed

6 files changed

+18
-17
lines changed

docs/UI-TESTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ You can run the tests locally with these steps:
2020
3. With the `WooCommerce` scheme selected in Xcode, navigate to Product > Test Plan and select `UITests`, or open the Test Navigator and select the `UITests` test plan.
2121
4. Navigate to Product > Test to run all the tests, or use the Test Navigator to run specific tests or test suites.
2222

23-
We also run the UI tests on CircleCI on every commit to the `develop` or `release/*` branches. (See the [CircleCI config](../.circleci/config.yml) for device and workflow details.)
23+
We also run the UI tests on CircleCI on every commit to the `trunk` or `release/*` branches. (See the [CircleCI config](../.circleci/config.yml) for device and workflow details.)
2424

2525
## Adding tests
2626

docs/app-local-settings.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ Initial goals were:
88
- make data typed
99
- inject storage layer as dependency.
1010

11-
Retrieving and storing the data is done via [`AppSettingsAction`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Yosemite/Yosemite/Actions/AppSettingsAction.swift) and most of the logic happens in [`AppSettingsStore`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Yosemite/Yosemite/Stores/AppSettingsStore.swift).
11+
Retrieving and storing the data is done via [`AppSettingsAction`](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Yosemite/Yosemite/Actions/AppSettingsAction.swift) and most of the logic happens in [`AppSettingsStore`](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Yosemite/Yosemite/Stores/AppSettingsStore.swift).
1212
There are a few data models + plist files separated for specific features and use cases.
1313

1414
## General use cases
1515

16-
- [`GeneralAppSettings`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Storage/Storage/Model/GeneralAppSettings.swift) handles settings universal to all stores.
17-
- [`GeneralStoreSettings`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Storage/Storage/Model/GeneralStoreSettings.swift) handles settings unique for each store. Cleared on logout.
18-
- [`StoredProductSettings`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Networking/Networking/Model/Product/StoredProductSettings.swift) handles products-specific settings, unique for each store. Cleared on logout.
19-
- [`StoredOrderSettings`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Networking/Yosemite/Model/Product/StoredOrderSettings.swift) handles orders-specific settings, unique for each store. Cleared on logout.
16+
- [`GeneralAppSettings`](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Storage/Storage/Model/GeneralAppSettings.swift) handles settings universal to all stores.
17+
- [`GeneralStoreSettings`](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Storage/Storage/Model/GeneralStoreSettings.swift) handles settings unique for each store. Cleared on logout.
18+
- [`StoredProductSettings`](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Networking/Networking/Model/Product/StoredProductSettings.swift) handles products-specific settings, unique for each store. Cleared on logout.
19+
- [`StoredOrderSettings`](https://github.com/woocommerce/woocommerce-ios/blob/develop/Yosemite/Yosemite/Model/Orders/StoredOrderSettings.swift) handles orders-specific settings, unique for each store. Cleared on logout.
2020

2121

2222
## How to add new property

docs/creating-core-data-model-versions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ The sequential version numbers are important because that sequence is used by th
1212

1313
## Avoid Modifying Existing Model Versions
1414

15-
Once a model version is merged in `develop`, consider creating a new model version instead. This helps us avoid issues like:
15+
Once a model version is merged in `trunk`, consider creating a new model version instead. This helps us avoid issues like:
1616

17-
- Different model version sequences between production and `develop`.
17+
- Different model version sequences between production and `trunk`.
1818
- Inconsistent model version references if multiple model versions, created by different developers, refer to the same model version.
1919

2020
These scenarios can lead to users' databases to be incompatible with the current model and they would be **unable to load** their data. The app would end up recreating the database. It's not an ideal scenario.
2121

22-
Also, avoid modifying model versions in release branches. If possible, model version changes should be done and merged swiftly in `develop`.
22+
Also, avoid modifying model versions in release branches. If possible, model version changes should be done and merged swiftly in `trunk`.
2323

2424
## Always Add Unit Tests
2525

docs/fakeable.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ Instantiating models for tests is not a simple task. Sometimes, the initializer
44
This inconvenience hurts our ability to efficiently unit test our app, which could discourage members from writing them at all.
55

66
To help with this, we have introduced a new framework called `Fakes.framework`. This framework defines `.fake()` functions for all of our networking models.
7-
The `.fake()` function instantiates a type with fake values. As of now, we are [defining](https://github.com/woocommerce/woocommerce-ios/blob/develop/Fakes/Fakes/Fake.swift) fake values as empty values.
7+
The `.fake()` function instantiates a type with fake values. As of now, we are [defining](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Fakes/Fakes/Fake.swift) fake values as empty values.
88

9-
This, in conjunction with the [copiable pattern](https://github.com/woocommerce/woocommerce-ios/blob/develop/docs/copiable.md) allow us to write tests like:
9+
This, in conjunction with the [copiable pattern](https://github.com/woocommerce/woocommerce-ios/blob/trunk/docs/copiable.md) allow us to write tests like:
1010

1111
```swift
1212
func test() {
1313
// Given
1414
let initialProduct = Product.fake()
1515
let expectedProduct = initialProduct.copy(name: "new-name")
1616
let ViewModel = ViewModel(product: initialProduct)
17-
17+
1818
// When
1919
viewModel.updateName("new_name")
20-
20+
2121
// Then
2222
XCTAssertEqual(viewModel.product, expectedProduct)
2323
}
@@ -49,14 +49,14 @@ To generate a `fake()` method:
4949
$ rake generate
5050
```
5151

52-
This will update the [Fakes.generated](https://github.com/woocommerce/woocommerce-ios/blob/develop/Fakes/Fakes/Fakes.generated.swift) file with the new `fake()` method.
52+
This will update the [Fakes.generated](https://github.com/woocommerce/woocommerce-ios/blob/trunk/Fakes/Fakes/Fakes.generated.swift) file with the new `fake()` method.
5353

5454
5. Compile the project.
5555

5656

5757
## Modifying The Fakeable Code Generation
5858

59-
The [`rake generate`](../Rakefile) command executes the Sourcery configuration files located in the [`CodeGeneration/Sourcery/Fakes` folder](../CodeGeneration/Sourcery/Fakes).
59+
The [`rake generate`](../Rakefile) command executes the Sourcery configuration files located in the [`CodeGeneration/Sourcery/Fakes` folder](../CodeGeneration/Sourcery/Fakes).
6060

6161
```
6262
Networking module Networking-Fakes.yaml

fastlane/Fastfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ platform :ios do
8686
# bundle exec fastlane code_freeze
8787
# bundle exec fastlane code_freeze skip_confirm:true
8888
#####################################################################################
89-
desc 'Creates a new release branch from the current develop'
89+
desc 'Creates a new release branch from the current trunk'
9090
lane :code_freeze do |options|
9191
old_version = ios_codefreeze_prechecks(options)
9292

@@ -115,7 +115,7 @@ platform :ios do
115115
# bundle exec fastlane complete_code_freeze
116116
# bundle exec fastlane complete_code_freeze skip_confirm:true
117117
#####################################################################################
118-
desc 'Creates a new release branch from the current develop'
118+
desc 'Creates a new release branch from the current trunk'
119119
lane :complete_code_freeze do |options|
120120
ios_completecodefreeze_prechecks(options)
121121
ios_localize_project

fastlane/Pluginfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ group :screenshots, optional: true do
66
gem 'rmagick', '~> 3.2.0'
77
end
88

9+
# TODO: Update to the next major version after: https://github.com/wordpress-mobile/release-toolkit/pull/319
910
gem 'fastlane-plugin-wpmreleasetoolkit', '~> 2.0'
1011
gem 'fastlane-plugin-sentry', '~> 1.0'
1112
gem 'fastlane-plugin-appcenter', '~> 1.6'

0 commit comments

Comments
 (0)