Merge pull request #191 from yazansalhi/master

yajra · web-flow · commit 7f3ecd1a22c9 · 2025-01-18T19:11:37.000+08:00
Fix: Avoid redundant call to buildExcelFile in csv method
diff --git a/src/Services/DataTable.php b/src/Services/DataTable.php
@@ -530,7 +530,7 @@ public function csv()
         }
 
         // @phpstan-ignore-next-line
-        return $this->buildExcelFile()->download($path, $this->csvWriter);
+        return $excelFile->download($path, $this->csvWriter);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ public function csv()`
`530`	`530`	`}`
`531`	`531`
`532`	`532`	`// @phpstan-ignore-next-line`
`533`		`- return $this->buildExcelFile()->download($path, $this->csvWriter);`
	`533`	`+ return $excelFile->download($path, $this->csvWriter);`
`534`	`534`	`}`
`535`	`535`
`536`	`536`	`/**`