Skip to content

Commit b431d8d

Browse files
rajveermalviyagnprice
authored andcommitted
deps android: Upgrade Android Gradle Plugin to 8.9.1, from 8.5.2
Release notes: https://developer.android.com/build/releases/past-releases/agp-8-6-0-release-notes https://developer.android.com/build/releases/past-releases/agp-8-7-0-release-notes https://developer.android.com/build/releases/past-releases/agp-8-8-0-release-notes https://developer.android.com/build/releases/gradle-plugin (for 8.9, for now) Changes mostly seem to be bug fixes to various components. One notable change is that AGP version 8.9 now requires Android Studio Meerkat (2024.3.1 Patch 1). Additionally, use the new extension `toUri` to make the linter happy.
1 parent 522c026 commit b431d8d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

android/app/src/main/kotlin/com/zulip/flutter/ZulipPlugin.kt

+3-2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import androidx.core.app.NotificationCompat
1919
import androidx.core.app.NotificationManagerCompat
2020
import androidx.core.graphics.drawable.IconCompat
2121
import io.flutter.embedding.engine.plugins.FlutterPlugin
22+
import androidx.core.net.toUri
2223

2324
private const val TAG = "ZulipPlugin"
2425

@@ -64,7 +65,7 @@ private class AndroidNotificationHost(val context: Context)
6465
channel.name?.let { setName(it) }
6566
channel.lightsEnabled?.let { setLightsEnabled(it) }
6667
channel.soundUrl?.let {
67-
setSound(Uri.parse(it),
68+
setSound(it.toUri(),
6869
AudioAttributes.Builder().setUsage(AudioAttributes.USAGE_NOTIFICATION).build())
6970
}
7071
channel.vibrationPattern?.let { setVibrationPattern(it) }
@@ -199,7 +200,7 @@ private class AndroidNotificationHost(val context: Context)
199200
it.requestCode.toInt(),
200201
it.intent.let { intent -> Intent(
201202
intent.action,
202-
Uri.parse(intent.dataUrl),
203+
intent.dataUrl.toUri(),
203204
context,
204205
MainActivity::class.java
205206
).apply {

android/gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ android.enableJetifier=true
66
# Defining them here makes them available both in
77
# settings.gradle and in the build.gradle files.
88

9-
agpVersion=8.5.2
9+
agpVersion=8.9.1
1010

1111
# Generally update this to the version found in recent releases
1212
# of Android Studio, as listed in this table:

0 commit comments

Comments
 (0)