license: add extension to LICENSE file #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license file without the extension is shown as "raw" text file. The links do not work as they should. As this file should point to files with non Apache licenses (the most used case) it should be viewed as markdown.
|
The file view without extension https://github.com/ARMmbed/mbed-os/blob/master/LICENSE |
AnotherButler
approved these changes
Feb 19, 2019
cmonr
approved these changes
Feb 19, 2019
AnotherButler
pushed a commit
that referenced
this pull request
Feb 19, 2019
Apply changes from PR #954 to 5.11 to add markdown extension to license file references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license file without the extension is shown as "raw" text file. The links do not work as they should. As this file
should point to files with non Apache licenses (the most used case) it should be viewed as markdown.
This should address the issue found here ARMmbed/mbed-os#9502 (comment)
Reviewing https://help.github.com/articles/licensing-a-repository/ (they also mention either no extension or .md extension). We rather use .md extension so license can be viewed on Github and be navigated (see the main LICENSE file in the root, overview of all license files in the tree).
@ARMmbed/mbed-os-maintainers