Save subcategory results to json #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/benchmark.py
Outdated
| for subcategory in self._subcategories.keys(): | ||
| json_data[subcategory] = { | ||
| "workload_size": self._subcategories[subcategory]["workload_size"][self.warm_up_runs:times_invoked], # noqa | ||
| "start_times": self._subcategories[subcategory]["start_times"][self.warm_up_runs:times_invoked], |
There was a problem hiding this comment.
Here might be the source of the issue I've mentioned on mzd side. You cut subcategories' runs based on times_invoked as seen from outside of the llama generative loop.
There was a problem hiding this comment.
The problem was actually discarding warmup runs when they were already ignored by start_subcategory_measurement and finish_subcategory_measurement, which resulted in not meeting the minimum measurements count
jan-grzybek-ampere
approved these changes
Jul 9, 2024
|
@dkupnicki before merging, please take a look at review of complementary PR on mzd side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.