Fix issues with Firefox #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the message handling also fixes a bug (that at least existed on Firefox) where attempting to archive with an unconfigured ArchiveBox server would lead to an undefined type error instead of an error message that the server wasn't configured.
In Firefox, making requests directly from the options page (as we were in config-tab.js) violates CORS, so we have to send messages to the background script which then makes the requests to the server, as we're doing with other requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46
This PR fixes the most glaring compatibility issues with Firefox. Users should now be able to use and configure the extension similarly to Chrome. It's currently based on #47, so auto-archiving works as well. There may still be cases where behavior differs, more feedback and testing is appreciated.
The main issues in Firefox were: