Skip to content

Print warning if preview version #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2025

Conversation

liliankasem
Copy link
Member

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Details

  • Refactored the CliVersion prop so we get the full version and not the assembley version. This ensures that when func --version is called, the user should see 4.0.8050-preview1and not just4.0.8050`.
  • Updated project version to add -preview1 suffix
  • Implemented WarnIfPreviewVersion method to notify users that they are on a preview version of the CLI. This should print when in preview when func, func --version, func init, func new, or func start is invoked.

Screenshot 2025-04-29 at 5 30 24 PM

@liliankasem liliankasem marked this pull request as ready for review May 5, 2025 19:22
@liliankasem liliankasem requested review from a team as code owners May 5, 2025 19:22
Copy link
Contributor

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder about the warning being before the actual printing of the version in effect, but I see the comment thread there. I think it is more consistent if always the first thing, which overrides my personal preference for it coming after the version is actually printed.

Small wording change requested just to make things a bit clearer for some of these actions.

Co-authored-by: Matthew Henderson <mattchenderson@users.noreply.github.com>
@liliankasem liliankasem merged commit f7fcfc1 into feature/linux-arm64 May 7, 2025
3 checks passed
@liliankasem liliankasem deleted the liliankasem/preview-prep branch May 7, 2025 22:39
liliankasem added a commit that referenced this pull request May 7, 2025
liliankasem added a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants