-
Notifications
You must be signed in to change notification settings - Fork 450
Print warning if preview version #4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder about the warning being before the actual printing of the version in effect, but I see the comment thread there. I think it is more consistent if always the first thing, which overrides my personal preference for it coming after the version is actually printed.
Small wording change requested just to make things a bit clearer for some of these actions.
Co-authored-by: Matthew Henderson <mattchenderson@users.noreply.github.com>
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
Details
func --version
is called, the user should see 4.0.8050-preview1and not just
4.0.8050`.-preview1
suffixWarnIfPreviewVersion
method to notify users that they are on a preview version of the CLI. This should print when in preview whenfunc
,func --version
,func init
,func new
, orfunc start
is invoked.