Update CI to package linux arm64 + build arm64 host #4403
Conversation
| @@ -146,6 +146,16 @@ jobs: | |||
| arguments: -c Release -r linux-x64 -o $(Build.SourcesDirectory)/pkg_output/linux/linux-x64 | |||
| workingDirectory: $(Build.SourcesDirectory)/src/CoreToolsHost | |||
|
|
|||
| # do we need to build a linux-arm64 version? | |||
There was a problem hiding this comment.
Is it a requirement to create a custom host with linux-arm64? If so we probably would need to publish it similar to linux-x64
Today we build win-x64, win-arm64, and linux-x64, so it would make sense to also include linux-arm64 but just wanted to double check!
There was a problem hiding this comment.
I am not familiar with custom host so I don't know if this is a requirement or not, but since I saw we have win arm64, I thought it made sence to also do linux
There was a problem hiding this comment.
hmm ok I see. Maybe we should check with Fabio first to see if this makes sense to add, since VS uses the custom host but I'm not sure if linux-arm64 is a valid use case or not
There was a problem hiding this comment.
LGTM! I just left the comment on double checking that linux-arm64 is a requirement for the custom host, but imo it makes sense to include it. I would just also run this through the consolidated pipeline once all the changes are in just to make sure that the artifact assembler runs as expected producing the correct set of artifacts!
Issue describing the changes in this PR
resolves #4287
Pull request checklist