Skip to content

More housekeeping on versions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

More housekeeping on versions #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdffe4e
More housekeeping on versions
enovella Mar 19, 2019
15057dd
bugfix (*unix box)
enovella Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ _md5: 2dd2eeeda08ac8c15be8a9f2d01adbe8_
Since you're an elite Android reverser, I'm sure you already have Smali and Baksmali on your path. If for some strange reason it's not already installed, this should get you started, but please examine it carefully before running:

```bash
mkdir ~/bin || cd ~/bin
curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/smali-2.2.5.jar && mv smali-*.jar smali.jar
curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/baksmali-2.2.5.jar && mv baksmali-*.jar baksmali.jar
mkdir ~/bin && cd ~/bin || cd ~/bin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why run this command twice? And why only run that command if mkdir creates a new directory? The code previously reads "attempt to create directory and then, regardless of what happens, change directory into ~/bin", but now it reads "create directory and if successful change directory to ~/bin and then change directory to ~/bin"

curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/smali-2.2.6.jar && mv smali-*.jar smali.jar
curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/baksmali-2.2.6.jar && mv baksmali-*.jar baksmali.jar
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good direction, but I can't accept this PR with the other change. Also, the newest version is 2.2.7 now.

curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/smali
curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/baksmali
chmod +x ./smali ./baksmali
Expand Down