Skip to content

Release 0.6.1 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Release 0.6.1 #8

merged 1 commit into from
Nov 1, 2024

Conversation

CoderGamester
Copy link
Owner

@CoderGamester CoderGamester commented Nov 1, 2024

Fix:

  • Fixed an issue that would crash the execution when calling Remove() & RemoveOrigin from ObservableResolverDictionary

Summary by CodeRabbit

  • Bug Fix: Fixed a critical issue causing crashes when calling Remove() and RemoveOrigin from ObservableResolverDictionary.

Summary by CodeRabbit

  • Bug Fixes

    • Resolved crash issue when using Remove() and RemoveOrigin methods in the Observable Resolver Dictionary.
  • New Features

    • Updated changelog to reflect version 0.6.1, including the recent bug fix.
  • Chores

    • Incremented package version from 0.6.0 to 0.6.1 and adjusted Unity version requirement in the package.json file.

- Fixed an issue that would crash the execution when calling *Remove()* & *RemoveOrigin* from *ObservableResolverDictionary*
Copy link

coderabbitai bot commented Nov 1, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes in this pull request include an update to the changelog for version 0.6.1, which documents a fix for a crash issue in the ObservableResolverDictionary methods Remove() and RemoveOrigin. The implementation of these methods has been modified to improve error handling by checking for key existence before attempting removal. Additionally, the package.json file has been updated to reflect the new version number and a change in the Unity version requirement.

Changes

File Change Summary
CHANGELOG.md Added entry for version 0.6.1, documenting a fix for crash issue in Remove() and RemoveOrigin methods.
Runtime/ObservableDictionary.cs Updated Remove and RemoveOrigin methods to check for key existence using TryGetValue to enhance error handling.
package.json Updated version from 0.6.0 to 0.6.1 and modified Unity version requirement from 2022.4 to 2022.3.

Poem

In the code where rabbits play,
A fix was made, hip-hip-hooray!
With keys now checked, no crashes near,
Our methods dance with joy and cheer.
Version bumps and changelogs bright,
Hoppy coding, all feels right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 1, 2024

Image description CodeRabbit

Walkthrough

The changes include updates to the Remove and RemoveOrigin methods in the ObservableResolverDictionary class in the Runtime/ObservableDictionary.cs file. The modifications ensure proper handling of cases where keys are not found in the dictionary by using TryGetValue. This resolves a critical issue that was causing crashes when calling these methods.

Changes

File Summary
Runtime/ObservableDictionary.cs Updates the Remove and RemoveOrigin methods in ObservableResolverDictionary to handle cases where keys are not found in the dictionary by using TryGetValue.
CHANGELOG.md Fixes a critical issue causing crashes when calling Remove() & RemoveOrigin from ObservableResolverDictionary.

🐇 "In code we hop, bugs we squash,
Observable dictionaries, we refresh with panache.
No more crashes, no more strife,
With TryGetValue, we bring new life." 🥕


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 7279e03 and 92827e0 commits.
Files selected (2)
  • CHANGELOG.md (1)
  • Runtime/ObservableDictionary.cs (2)
Files ignored due to filter (1)
  • package.json
Review comments generated (5)
  • Review: 3
  • LGTM: 2

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Comment on lines +456 to +458
if(!Dictionary.TryGetValue(key, out var value)) return false;

var pair = _toOrignResolver(key, value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The code change in this section updates the Remove method in the ObservableResolverDictionary class. The modification introduces a check using TryGetValue to handle cases where the key is not found in the dictionary. This is an improvement as it prevents an exception from being thrown when attempting to access a non-existent key.

Comment on lines 4 to 14
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [0.6.1] - 2024-11-01

**Fix**:
- Fixed an issue that would crash the execution when calling *Remove()* & *RemoveOrigin* from *ObservableResolverDictionary*

## [0.6.0] - 2023-08-05

- Improved the *ObservableResolverList* and *ObservableResolverDictionary* data types to properly resolve lists and dictionaries with different data types from the original collection.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Note: This review was outside of the patch, but no patch was found that overlapped with it. Original lines [22-22]

There's a syntax error in the add function.

-    retrn z
+    return z

Comment on lines +7 to +11
## [0.6.1] - 2024-11-01

**Fix**:
- Fixed an issue that would crash the execution when calling *Remove()* & *RemoveOrigin* from *ObservableResolverDictionary*

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

The changelog entry for Release 0.6.1 is missing the release date. Please update it to include the correct date.

## [0.6.1] - 2024-11-01

**Fix**:
- Fixed an issue that would crash the execution when calling *Remove()* & *RemoveOrigin* from *ObservableResolverDictionary*

@CoderGamester CoderGamester merged commit 04267c7 into master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant