Skip to content

Update Twitter/X sharing meta tags #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

Update Twitter/X sharing meta tags #1611

merged 1 commit into from
May 29, 2024

Conversation

fturmel
Copy link
Collaborator

@fturmel fturmel commented May 29, 2024

closes #1610

Per the docs:

  • twitter:url is not a thing
  • we should be using name instead of property for the tag keys

@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 992bdce
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/66567d8190b54b000892b44b
😎 Deploy Preview https://deploy-preview-1611--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fturmel fturmel marked this pull request as draft May 29, 2024 00:57
@fturmel fturmel marked this pull request as ready for review May 29, 2024 01:14
@shiffman
Copy link
Member

Thank you @fturmel!

@shiffman shiffman merged commit 6c39579 into CodingTrain:main May 29, 2024
5 checks passed
@fturmel fturmel deleted the PR/update-twitter-meta-tags branch May 29, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Social Sharing (Twitter)
2 participants
@fturmel @shiffman