Skip to content

Update Node.js to 20 LTS #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update Node.js to 20 LTS #1632

merged 1 commit into from
Jul 4, 2024

Conversation

fturmel
Copy link
Collaborator

@fturmel fturmel commented Jun 24, 2024

With 22 recently released, 20 is now the new active LTS. It's also stable on AWS lambda so the timing should be good to migrate. We should be doing this mostly to keep up with the ecosystem and get some free perf improvements.

Just before merging this PR, the environment variable AWS_LAMBDA_JS_RUNTIME on Netlify should also be set to nodejs20.x

https://nodejs.org/en/about/previous-releases
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 037e5de
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/6678c7fa707cdc00086b495d
😎 Deploy Preview https://deploy-preview-1632--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shiffman shiffman self-assigned this Jul 3, 2024
@shiffman
Copy link
Member

shiffman commented Jul 4, 2024

I've updated the environment variable, merging, thank you @fturmel!

@shiffman shiffman merged commit a8dc2a7 into CodingTrain:main Jul 4, 2024
5 checks passed
@fturmel fturmel deleted the PR/node-20 branch July 4, 2024 11:03
@fturmel
Copy link
Collaborator Author

fturmel commented Jul 4, 2024

@shiffman Last time we upgraded Node was in late 2022, and I just realized that there has been a product update since then that makes the use of the environment variable redundant. Netlify Functions will inherit the version defined in the .nvmrc file as long as it is supported.

@shiffman
Copy link
Member

shiffman commented Jul 4, 2024

Ah, thank you @fturmel, good to know! Would you advise that I remove the environment variable or leave it for now?

@fturmel
Copy link
Collaborator Author

fturmel commented Jul 4, 2024

Ah, thank you @fturmel, good to know! Would you advise that I remove the environment variable or leave it for now?

We can remove it, the simpler the configuration the better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants