Skip to content

Showcase Submission for challenges/10-dfs-maze-generator #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ch00ooch00oo
Copy link
Collaborator

Thank you Ijee for your contribution! A member of the Coding Train team will review it shortly.

preview image

@ch00ooch00oo ch00ooch00oo added the showcase Passenger Showcase Submission label Jul 14, 2024
Copy link

netlify bot commented Jul 14, 2024

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 1b709ac
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/6693a51f151e94000888bf27
😎 Deploy Preview https://deploy-preview-1659--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ijee
Copy link
Contributor

Ijee commented Jul 14, 2024

I wasn't entirely sure about the showcase track/category just in case there's a better fit.

Edit: can I somehow change the preview image? I forgot about the 16:9 aspect ratio.

@shiffman
Copy link
Member

Hi @Ijee this is incredible work! You can always change the image by making additional commits / a new PR to this branch, but it probably makes sense for me to merge it first (the image will auto-reszie/crop) and if you can open a new PR later anyitme you want! I think this is a great challenge to associate with your project!

@shiffman shiffman merged commit 75a4edb into main Jul 15, 2024
5 checks passed
@shiffman shiffman deleted the showcase-ijee-1720952091 branch July 15, 2024 11:13
@Ijee
Copy link
Contributor

Ijee commented Jul 15, 2024

Hi @Ijee this is incredible work! You can always change the image by making additional commits / a new PR to this branch, but it probably makes sense for me to merge it first (the image will auto-reszie/crop) and if you can open a new PR later anyitme you want! I think this is a great challenge to associate with your project!

Thank you and also thanks for merging this 👍

At some point I questioned myself why I spent so much time on this and there's definitely more things I want to add
(ida*, jump point search and a few others) but I needed a break from it. I'll see what comes of this project once I get back
to it.

The functionality is all there and I basically only need to implement an abstract class to get new algorithms in which is pretty nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Passenger Showcase Submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants