-
Notifications
You must be signed in to change notification settings - Fork 268
Allow selecting new problem types as part of the problem entity. #2979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Mar 29, 2025
8289465
to
9251876
Compare
eldering
reviewed
Mar 30, 2025
570510e
to
4d6d542
Compare
vmcj
reviewed
Mar 30, 2025
eldering
reviewed
Mar 31, 2025
While you can select the new types, they won't function yet. Part of DOMjudge#2525 Problem types are defined here: https://icpc.io/problem-package-format/spec/2023-07-draft.html#type
eldering
approved these changes
Apr 6, 2025
mpsijm
reviewed
Apr 23, 2025
Comment on lines
+341
to
+343
if (!($this->types & self::TYPE_PASS_FAIL) xor ($this->types & self::TYPE_SCORING)) { | ||
throw new Exception("Invalid problem type: must be exactly one of 'pass-fail' or 'scoring'."); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that pass-fail
is implied when it is not provided. For example, type: interactive
implies type: [pass-fail, interactive]
. I noticed this when doing a test upload today 😂
See also: Kattis/problem-package-format#440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While you can select the new types, they won't function yet.
Part of #2525
Problem types are defined here: https://icpc.io/problem-package-format/spec/2023-07-draft.html#type