Skip to content

mb/protectli/vault_adl_n/variants/vp32xx/overridetree.cb: disable ASP… #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dasharo-24.02.1
Choose a base branch
from

Conversation

mkopec
Copy link
Member

@mkopec mkopec commented May 20, 2025

…M on x4 slot

Change-Id: Idd8a1d1b4cade0725f8ad8487f5cda168152b9d8

@mkopec mkopec changed the base branch from dasharo to dasharo-24.02.1 May 20, 2025 13:29
@mkopec mkopec marked this pull request as ready for review May 20, 2025 14:35
…M on x4 slot

Change-Id: Idd8a1d1b4cade0725f8ad8487f5cda168152b9d8
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
@mkopec mkopec marked this pull request as draft May 20, 2025 14:36
mkopec added 2 commits May 20, 2025 17:22
Change-Id: Ibb38ea1306468147afbb97c09fb76e9f21df9c3b
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Change-Id: I3649e32af79a4cfb2e177a05ceeec8d4fdcd7db6
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
@mkopec mkopec marked this pull request as ready for review May 20, 2025 15:27
@mkopec mkopec requested a review from macpijan May 20, 2025 15:28
mkopec added 2 commits May 26, 2025 12:30
These features are incompatible with some cards that may be plugged into
this slot, such as a 4x i225 network adapter connected via a NVMe to
PCIe x4 riser.

Change-Id: I48dc9c0f2857a6c3b32db28fcc129737fa0865a8
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Change-Id: I9f0c241c18acd37bb4d4ddd40120bf096440cda2
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first and third commits lack reasoning behind the changes, but otherwise LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants