Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoexposure example restoration #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Autoexposure example restoration #728
Changes from 16 commits
096e09d
4fd700f
f93bb0f
6152f96
2311521
52e7ab2
1cc26bd
6922d0c
6e6eb64
603a92f
810a6ac
69a73c1
72e0bc5
4c70cf5
d9d6dd8
305f7e7
3f4f6e9
515512a
77f5756
1919e53
4c58238
3c3f8b8
b0e0750
e8e46c9
ee5affe
56389f4
23771d1
ac39039
49a8049
8a10ae2
6b01b6d
4129afe
f95f1c1
1a58273
b6e1f57
5239c29
0df9ba6
06c915e
90d20c4
26a4ed2
4edd38c
f1e3e98
ce2ca41
f1b7d17
83ac633
2b5e502
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, you've set the min and max equal to each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. its also more useful to take a precomputed
minLumaLog2
andlumaLog2Range
(diff between log of max and log of min)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still outstanding for the geom meter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually require/expect a
TexAccessor::toXYZ
static memberfloat32_t3x3
variable :Pthink of it as the
TexAccessor
telling everyone what the colorspace of the image isThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done