Add ability to exclude by type name or attribute #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to exclude types from service registrations based on either their type name (using wildcards) or by the presence of a specific attribute. Key changes include updating the AttributeModel to support new exclusion parameters, extending the attribute generator to include new properties with updated documentation, and adjusting the dependency injection filtering along with adding corresponding tests.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ServiceScan.SourceGenerator/Model/AttributeModel.cs | Added new parameters to capture exclusion options and updated the Create method accordingly. |
| ServiceScan.SourceGenerator/GenerateAttributeSource.cs | Introduced new attribute properties and adjusted documentation. |
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.FilterTypes.cs | Incorporated new logic to filter out types based on exclusion rules. |
| ServiceScan.SourceGenerator.Tests/AddServicesTests.cs | Added tests for excluding services by type name and attribute. |
| README.md | Updated usage documentation to reflect the new exclusion properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.