-
Notifications
You must be signed in to change notification settings - Fork 15
Complete CCPPization of RK microphysics #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
All GNU regression tests passed except for newly introduced RK test. Will run full suite of tests again prior to final merging after code reviews.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @jimmielin! I did have one request to add a namelist flag to the RK snapshot test, but if it doesn't work then we can just worry about it later. Thanks!
ncdata_check = '/glade/campaign/cesm/community/amwg/sima_baselines/cam_sima_test_snapshots/cam_ne3pg3_rasch_kristjansson_rk_stratiform_snapshot_derecho_gnu_after_c20250328.nc' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently realized that when possible we should have the model exit (and thus induce a test failure) whenever the snapshot file comparison finds significant differences. I believe this can be done for this test by adding the following namelist setting to this file:
ncdata_check_err = .true.
Of course if that ends up not working for this particular test please let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nusbaume! Sadly I can't enable this option because it'll abort the model even with round-off differences. Right now the physics check data has round-off level differences against the snapshot
********** Physics Check Data Results **********
TIMESTEP: 1
Variable # Diffs Max Diff Max Diff loc (rank, col, lev)
-------- ------- -------- -----------------------------
air_temperature 127 0.22E-15 (19,3,22)
geopotential_height_wrt_surface 152 0.38E-15 (14,20,19)
geopotential_height_wrt_surface_at_interface 150 0.42E-15 (10,4,25)
tendency_of_air_temperature_due_to_model_physics 171 0.10E-14 (19,11,24)
cloud_liquid_water_mixing_ratio_wrt_moist_air_and_condensed_water
2212 0.85E-15 (7,13,23)
cloud_ice_mixing_ratio_wrt_moist_air_and_condensed_water
2076 0.76E-15 (7,6,24)
water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water
131 0.22E-15 (12,4,26)
********** End Physics Check Data Results **********
It will run for all the time slices in the snapshot to completion with comparable round-off differences but the model will abort on timestep 1 if ncdata_check_err = .true.
ERROR: Difference(s) found during ncdata check at /glade/derecho/scratch/hplin/aux_sima_gnu_20250516111902/SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_rk_stratiform_derecho.GC.aux_sima_gnu_20250516111902/bld/atm/obj/phys_init/physics_inputs.F90:1056
Tag name (required for release branches): TBD - increment Y version
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system: N/A
Describe any changes made to the namelist: See atmos_phys updates
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>
)If there are new failures (compared to the
test/existing-test-failures.txt
file),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: