Skip to content

Impose range limits on mid-level pressure in MPAS dynamics-physics coupling #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

kuanchihwang
Copy link
Collaborator

Tag name (required for release branches):

None

Originator(s):

kuanchihwang

Descriptions (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

This PR ports a bug fix from ESCOMP/CAM#1304 to CAM-SIMA. In MPAS dynamics-physics coupling, mid-level pressure is not bounded by interface pressure. In high-resolution simulations, the former could exceed the latter, leading to a model crash in physics. Therefore, impose range limits on mid-level pressure to ensure that it is bounded by interface pressure.

Closes #388

Describe any changes made to the build system:

None

Describe any changes made to the namelist:

None

List any changes to the defaults for the input datasets (e.g., boundary datasets):

None

List all files eliminated and why:

None

List all files added and what they do:

None

List all existing files that have been modified, and describe the changes:

M       src/dynamics/mpas/dyn_coupling.F90
  * Limit mid-level pressure within the range of interface pressure
  * Remove debugging block
  * Correct code comments

Regression tests:

No changes to any existing tests. All tests pass with respect to the last baseline, sima0_05_001.

@kuanchihwang kuanchihwang requested review from mgduda and nusbaume May 21, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant