Skip to content

Update MUSICA library #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

mattldawson
Copy link
Collaborator

Tag name (required for release branches):
Originator(s): Matt Dawson

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Updates to use latest MUSICA library and run Terminator and Chapman configurations. closes #321

in draft pending merging of ESCOMP/atmospheric_physics#249
I'll run the tests and finish the PR description once that's merged.

Describe any changes made to build system:

Describe any changes made to the namelist:

List any changes to the defaults for the input datasets (e.g. boundary datasets):

List all files eliminated and why:

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MUSICA library integration to support the latest library versions and configurations, including both Terminator and Chapman modes. Key changes include logging message updates in the MUSICA namelist routines, new dependency initialization logic requiring a physical suite name, updated linker flags and build options in the build scripts, and revised submodule commit pointers.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/physics/utils/musica_sima_namelist.F90 Updated log message text for MUSICA configuration.
src/physics/utils/musica_ccpp_dependencies.F90 Added use of spmd_utils, enhanced logging messages with stubbed dependencies, and introduced a new parameter (phys_suite_name) in initialization.
src/physics/ncar_ccpp Updated submodule commit pointer.
src/control/cam_initfiles.F90 Added check to enforce presence of the initial dataset.
src/control/cam_comp.F90 Passed the new phys_suite_name argument to dependencies initialization.
cime_config/buildlib Updated MUSICA linker flags and added a new CMake build flag.
cime_config/atm_musica_config.py Updated MUSICA_TAG to the new commit version.
.gitmodules Revised ncar-physics submodule URL and commit tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant