[New] Add items to portal #586
Open
+339
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
requested review from
a team,
mhdostal and
pgruenler
and removed request for
a team
yo1995
commented
May 6, 2025
yo1995
requested review from
a team,
dfeinzimer and
des12437
and removed request for
mhdostal,
pgruenler and
a team
|
@mhdostal @pgruenler I've reset the reviewers… no need to review if you haven't started yet, but feel free to add comments if you have already done some. |
dfeinzimer
reviewed
May 9, 2025
| } | ||
| } | ||
| .task { | ||
| try? await item.thumbnail?.load() |
There was a problem hiding this comment.
I never seem to get the thumbnail. Looks like this throws the following error. Expected?
ArcGIS.IllegalStateError(details: "Loadable image doesn't have a URI.")
There was a problem hiding this comment.
Let me ask around to see if this is a known issue…
There was a problem hiding this comment.
Haven't heard an confirmative response yet… will request review again once I hear back.
des12437
reviewed
May 9, 2025
Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Add items to portalinCloud and Portalcategory.URL to README
Linked Issue(s)
swift/issues/6820swift/issues/6785How To Test
You have to use the latest daily to test the add item feature, as there is a fix in 6785.
Screenshots
To Discuss
The sample design was dated and only Qt has implemented it. Therefore, I made some enhancements comparing to the Qt implementation while trying to keep consistent with the design to showcase the addItem and deleteItem endpoints.