Fix breaking builds by removing assertj dependency and test usage
#1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
referenced
this pull request
Jun 3, 2023
|
No, I wanted to add it on purpose. But maybe EDIT: Ok, version should come from parent pom, but maybe snapshot build was missing? I'll fix that. |
|
Will create an issue indicating addition of AssertJ as well. Problem turned out to be that version definition was added in |
|
Created #1041 as place holder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix failing builds. I suppose
assertjdependency was added automatically by IDE, by accident? 🤔Please feel free to close the PR if this seems unncessary, thanks! 🙏🏼