Skip to content

filter generator: create child object context when writing start object. fixes #890 #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

filter generator: create child object context when writing start object. fixes #890 #891

merged 1 commit into from
Jan 17, 2023

Conversation

DemonicTutor
Copy link
Contributor

@DemonicTutor DemonicTutor commented Jan 12, 2023

Fixes #890.

@cowtowncoder
Copy link
Member

Thank you @DemonicTutor! Happy to merge this ASAP.

Just one clerical thing: have I yet asked for a CLA? If not, it's here

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(and alternatively Corporate CLA if preferred)

and the usual mechanism is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.
Only needs to be done once for all future contributions.
(also if you have sent one earlier let me know; I didn't see one but might have missed it).

Looking forward to merging this!

@cowtowncoder
Copy link
Member

Oh also, not sure if it's easy to rebase but this could be merged into 2.14 branch. Or I can try to cherry-pick after merge to 2.15.

@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Jan 14, 2023
@DemonicTutor
Copy link
Contributor Author

DemonicTutor commented Jan 16, 2023

@cowtowncoder hey! i sent you the requested document from my company mail account.

yeah if you are happy with this one as-is i can also open a Pull-Request against 2.14?

@cowtowncoder
Copy link
Member

cowtowncoder commented Jan 16, 2023

Thanks, I can see that now. And yes, the other request is fine; could have rebased this one but separate PR is ok too.

@cowtowncoder cowtowncoder merged commit 049992f into FasterXML:2.15 Jan 17, 2023
@cowtowncoder cowtowncoder removed the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Jan 17, 2023
@DemonicTutor DemonicTutor deleted the f/ms/filteringGeneratorDelegate branch May 17, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilteringGeneratorDelegate does not create new filterContext if tokenFilter is null
2 participants