Skip to content

Implement new EnumResolver.constructUsingIndex() via AnnotatedClass instead of Class<?> #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1925,6 +1925,7 @@ private KeyDeserializer _createEnumKeyDeserializer(DeserializationContext ctxt,
EnumResolver enumRes = constructEnumResolver(enumClass, config, beanDesc);
EnumResolver byEnumNamingResolver = constructEnumNamingStrategyResolver(config, enumClass, beanDesc.getClassInfo());
EnumResolver byToStringResolver = EnumResolver.constructUsingToString(config, beanDesc.getClassInfo());
EnumResolver byIndexResolver = EnumResolver.constructUsingIndex(config, beanDesc.getClassInfo());

// May have @JsonCreator for static factory method
for (AnnotatedMethod factory : beanDesc.getFactoryMethods()) {
Expand All @@ -1946,15 +1947,15 @@ private KeyDeserializer _createEnumKeyDeserializer(DeserializationContext ctxt,
ClassUtil.checkAndFixAccess(factory.getMember(),
ctxt.isEnabled(MapperFeature.OVERRIDE_PUBLIC_ACCESS_MODIFIERS));
}
return StdKeyDeserializers.constructEnumKeyDeserializer(enumRes, factory, byEnumNamingResolver, byToStringResolver);
return StdKeyDeserializers.constructEnumKeyDeserializer(enumRes, factory, byEnumNamingResolver, byToStringResolver, byIndexResolver);
}
}
throw new IllegalArgumentException("Unsuitable method ("+factory+") decorated with @JsonCreator (for Enum type "
+enumClass.getName()+")");
}
}
// Also, need to consider @JsonValue, if one found
return StdKeyDeserializers.constructEnumKeyDeserializer(enumRes, byEnumNamingResolver, byToStringResolver);
return StdKeyDeserializers.constructEnumKeyDeserializer(enumRes, byEnumNamingResolver, byToStringResolver, byIndexResolver);
}

/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -406,13 +406,14 @@ protected EnumKD(EnumResolver er, AnnotatedMethod factory) {
* @since 2.16
*/
protected EnumKD(EnumResolver er, AnnotatedMethod factory, EnumResolver byEnumNamingResolver,
EnumResolver byToStringResolver) {
EnumResolver byToStringResolver, EnumResolver byIndexResolver) {
super(-1, er.getEnumClass());
_byNameResolver = er;
_factory = factory;
_enumDefaultValue = er.getDefaultValue();
_byEnumNamingResolver = byEnumNamingResolver;
_byToStringResolver = byToStringResolver;
_byIndexResolver = byIndexResolver;
}


Expand Down Expand Up @@ -461,7 +462,7 @@ protected EnumResolver _resolveCurrentResolver(DeserializationContext ctxt) {

/**
* Since 2.16, {@link #_byToStringResolver} it is passed via
* {@link #EnumKD(EnumResolver, AnnotatedMethod, EnumResolver, EnumResolver)}, so there is no need for lazy
* {@link #EnumKD(EnumResolver, AnnotatedMethod, EnumResolver, EnumResolver, EnumResolver)}, so there is no need for lazy
* initialization. But kept for backward-compatilibility reasons.
*
* @deprecated Since 2.16
Expand All @@ -483,6 +484,14 @@ private EnumResolver _getToStringResolver(DeserializationContext ctxt)
return res;
}

/**
* Since 2.16, {@link #_byIndexResolver} it is passed via
* {@link #EnumKD(EnumResolver, AnnotatedMethod, EnumResolver, EnumResolver, EnumResolver)}, so there is no need for lazy
* initialization. But kept for backward-compatilibility reasons.
*
* @deprecated Since 2.16
*/
@Deprecated
private EnumResolver _getIndexResolver(DeserializationContext ctxt) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we can remove the last volatile in EnumKD

EnumResolver res = _byIndexResolver;
if (res == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,19 @@ public static KeyDeserializer constructEnumKeyDeserializer(EnumResolver enumReso
/**
* @since 2.16
*/
public static KeyDeserializer constructEnumKeyDeserializer(EnumResolver enumRes, EnumResolver byEnumNamingResolver, EnumResolver byToStringResolver) {
return new StdKeyDeserializer.EnumKD(enumRes, null, byEnumNamingResolver, byToStringResolver);
public static KeyDeserializer constructEnumKeyDeserializer(EnumResolver enumRes, EnumResolver byEnumNamingResolver, EnumResolver byToStringResolver,
EnumResolver byIndexResolver)
{
return new StdKeyDeserializer.EnumKD(enumRes, null, byEnumNamingResolver, byToStringResolver, byIndexResolver);
}

/**
* @since 2.16
*/
public static KeyDeserializer constructEnumKeyDeserializer(EnumResolver enumResolver, AnnotatedMethod factory,
EnumResolver enumNamingResolver, EnumResolver byToStringResolver) {
return new StdKeyDeserializer.EnumKD(enumResolver, factory, enumNamingResolver, byToStringResolver);
EnumResolver enumNamingResolver, EnumResolver byToStringResolver, EnumResolver byIndexResolver)
{
return new StdKeyDeserializer.EnumKD(enumResolver, factory, enumNamingResolver, byToStringResolver, byIndexResolver);
}

public static KeyDeserializer constructDelegatingKeyDeserializer(DeserializationConfig config,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ public static EnumResolver constructUsingToString(DeserializationConfig config,
* Enum value
*
* @since 2.15
* @deprecated Since 2.16. Use {@link #constructUsingIndex(DeserializationConfig, AnnotatedClass)} instead.
*/
@Deprecated
public static EnumResolver constructUsingIndex(DeserializationConfig config,
Class<Enum<?>> enumCls0)
{
Expand All @@ -258,6 +260,33 @@ public static EnumResolver constructUsingIndex(DeserializationConfig config,
_enumDefault(ai, enumCls), isIgnoreCase, false);
}

/**
* Factory method for constructing resolver that maps from index of Enum.values() into
* Enum value.
*
* @since 2.16
*/
public static EnumResolver constructUsingIndex(DeserializationConfig config, AnnotatedClass annotatedClass)
{
// prepare data
final AnnotationIntrospector ai = config.getAnnotationIntrospector();
final boolean isIgnoreCase = config.isEnabled(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS);
final Class<?> enumCls0 = annotatedClass.getRawType();
final Class<Enum<?>> enumCls = _enumClass(enumCls0);
final Enum<?>[] enumConstants = _enumConstants(enumCls0);
final Enum<?> defaultEnum = _enumDefault(ai, annotatedClass, enumConstants);

// finally, build
// from last to first, so that in case of duplicate values, first wins
HashMap<String, Enum<?>> map = new HashMap<>();
for (int i = enumConstants.length; --i >= 0; ) {
Enum<?> enumValue = enumConstants[i];
map.put(String.valueOf(i), enumValue);
}
return new EnumResolver(enumCls, enumConstants, map,
defaultEnum, isIgnoreCase, false);
}

/**
* Factory method for constructing resolver that maps the name of enums converted to external property
* names into Enum value using an implementation of {@link EnumNamingStrategy}.
Expand Down