-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add new DefaultTyping.NON_FINAL_AND_ENUMS
to allow Default Typing for Enum
s
#4159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
498d966
Fix for 3569
JooHyukKim a5ff9dd
Fix JavaDoc and etc...
JooHyukKim 614e30b
Clean up
JooHyukKim fb35da1
Update BaseMapTest.java
JooHyukKim 5ec00ec
Add new feature
JooHyukKim e4cca74
Merge branch '2.16' into 3569-fix
JooHyukKim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
...va/com/fasterxml/jackson/databind/jsontype/deftyping/AsWrapperArrayEnumDeser3569Test.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
package com.fasterxml.jackson.databind.jsontype.deftyping; | ||
|
||
import static com.fasterxml.jackson.databind.BaseMapTest.jsonMapperBuilder; | ||
import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
import com.fasterxml.jackson.annotation.JsonCreator; | ||
import com.fasterxml.jackson.annotation.JsonTypeInfo; | ||
import com.fasterxml.jackson.core.JsonProcessingException; | ||
import com.fasterxml.jackson.core.type.TypeReference; | ||
import com.fasterxml.jackson.databind.JavaType; | ||
import com.fasterxml.jackson.databind.ObjectMapper; | ||
import com.fasterxml.jackson.databind.jsontype.DefaultBaseTypeLimitingValidator; | ||
import org.junit.Test; | ||
|
||
/** | ||
* [databind#3569]: Unable to deserialize enum object with default-typed | ||
* {@link com.fasterxml.jackson.annotation.JsonTypeInfo.As#WRAPPER_ARRAY} and {@link JsonCreator} together. | ||
* | ||
* @since 2.15.4 | ||
*/ | ||
public class AsWrapperArrayEnumDeser3569Test | ||
{ | ||
static class Foo<T> { | ||
public T item; | ||
} | ||
|
||
enum Bar { | ||
ENABLED, DISABLED, HIDDEN; | ||
|
||
@JsonCreator | ||
public static Bar fromValue(String value) { | ||
String upperVal = value.toUpperCase(); | ||
for (Bar enumValue : Bar.values()) { | ||
if (enumValue.name().equals(upperVal)) { | ||
return enumValue; | ||
} | ||
} | ||
throw new IllegalArgumentException("Bad input [" + value + "]"); | ||
} | ||
} | ||
|
||
@Test | ||
public void testEnumAsWrapperArrayWithCreator() throws JsonProcessingException { | ||
ObjectMapper objectMapper = jsonMapperBuilder() | ||
.activateDefaultTyping( | ||
new DefaultBaseTypeLimitingValidator(), | ||
ObjectMapper.DefaultTyping.NON_FINAL, | ||
JsonTypeInfo.As.WRAPPER_ARRAY) | ||
.build(); | ||
|
||
Foo<Bar> expected = new Foo<>(); | ||
expected.item = Bar.ENABLED; | ||
|
||
// First, serialize | ||
String serialized = objectMapper.writeValueAsString(expected); | ||
|
||
// Then, deserialize with TypeReference | ||
assertNotNull(objectMapper.readValue(serialized, new TypeReference<Foo<Bar>>() {})); | ||
// And, also try as described in [databind#3569] | ||
JavaType javaType = objectMapper.getTypeFactory().constructParametricType(Foo.class, new Class[]{Bar.class}); | ||
assertNotNull(objectMapper.readValue(serialized, javaType)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.