Skip to content

Cache vcpkg binary cache for macOS #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 11, 2025

Conversation

mrotteveel
Copy link
Member

Due to microsoft/vcpkg-tool#1662, the original caching is no longer working.

@mrotteveel
Copy link
Member Author

@asfernandes Do you think generating the key based on the contents of vcpkg-custom is sufficient, or do you think I should take anything else into consideration?

@asfernandes
Copy link
Member

I don't think you need to hash vcpkg-custom. vcpkg will hash things by hemself.

@asfernandes
Copy link
Member

From one side, vcpkg handles all things about differences with its own hashing, so it would be a matter of get and update the cache.
From another side, that would accumulate things when we start to change versions (vcpkg, libraries, custom ports).
You don't need to hash the git submodule. We have a reference of it in vcpkg-configuration.json. So we can hash it and maybe vcpkg.json too.

@mrotteveel
Copy link
Member Author

From one side, vcpkg handles all things about differences with its own hashing, so it would be a matter of get and update the cache. From another side, that would accumulate things when we start to change versions (vcpkg, libraries, custom ports). You don't need to hash the git submodule. We have a reference of it in vcpkg-configuration.json. So we can hash it and maybe vcpkg.json too.

In the current setup, even if the hash changes, it will fetch a previous version of the cache, so accumulation can occur here as well (but I consider that not so big a problem, or we can sometimes do some manual cache maintenance by deleting (all) caches).

In any case, I'll add vcpkg-configuration.json and vcpkg.json to the hash (and remove vcpkg/**).

Sidequest: I noticed that vcpkg.json has "version-string": "5.0.0". Should that be updated to 6.0.0?

@mrotteveel
Copy link
Member Author

@asfernandes I think this is good to go. Do you agree?

@mrotteveel mrotteveel merged commit c5d2102 into FirebirdSQL:master May 11, 2025
25 checks passed
@mrotteveel
Copy link
Member Author

I'll also apply these changes to v5.0-release.

mrotteveel added a commit that referenced this pull request May 11, 2025
@mrotteveel mrotteveel deleted the vcpkg-cache branch May 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants