-
-
Notifications
You must be signed in to change notification settings - Fork 235
Cache vcpkg binary cache for macOS #8560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@asfernandes Do you think generating the key based on the contents of vcpkg-custom is sufficient, or do you think I should take anything else into consideration? |
I don't think you need to hash vcpkg-custom. vcpkg will hash things by hemself. |
From one side, vcpkg handles all things about differences with its own hashing, so it would be a matter of get and update the cache. |
In the current setup, even if the hash changes, it will fetch a previous version of the cache, so accumulation can occur here as well (but I consider that not so big a problem, or we can sometimes do some manual cache maintenance by deleting (all) caches). In any case, I'll add vcpkg-configuration.json and vcpkg.json to the hash (and remove vcpkg/**). Sidequest: I noticed that vcpkg.json has |
@asfernandes I think this is good to go. Do you agree? |
I'll also apply these changes to v5.0-release. |
Due to microsoft/vcpkg-tool#1662, the original caching is no longer working.