Skip to content

Request: Support timeout #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yutaroyamanaka
Copy link

Why

Hello, I appreciate the FlowiseAI project and find it very useful for hosting RAG applications. When using FlowiseAI's API in the production environment, I want to ensure that my code doesn't hang infinitely by setting the timeout.

Although it's possible to implement a timeout outside the SDK, I believe adding support for it directly in the SDK would be beneficial for others as well.

What

  • Add a new argument called timeout (default is None)
  • I found one of test cases broken. Therefore, I fixed this by mocking requests.post correctly.

@yutaroyamanaka
Copy link
Author

@HenryHengZJ
Sorry for bothering you.
I really appreciate if you have some feedbacks for me. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant