Skip to content

chore: upgrade demo app + Swift default template #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025
Merged

Conversation

zibs
Copy link
Contributor

@zibs zibs commented May 26, 2025

Fixes #1075 et al.
Fixes #1067
Fixed #1060

Description

This PR updates the example app to the latest RN version and updates the getting started instructions to align with the new Swift AppDelegate.

Steps to verify

I ran both platforms and logged in via both methods.

zibs added 3 commits May 26, 2025 13:02
- replaces existing demo app with newly bootstrapped app to avoid painstaking upgrade.
- replaces old UI with simpler more basic UI.
- uses Swift on iOS now
- adds bridging header for obj-c interop
@zibs zibs requested a review from Copilot May 26, 2025 21:23
Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: f7a24d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-app-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 4:31pm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the demo app to the latest React Native version, migrates Android build configs to Kotlin and updated SDK tools, replaces Java app classes with Kotlin templates, and aligns the iOS getting-started docs with the new Swift AppDelegate template.

  • Bumped Android SDK, NDK, build tools, added Kotlin plugin, and updated Gradle build scripts
  • Removed legacy Flipper Java code, added Kotlin MainApplication and MainActivity
  • Updated tests, Gemfile, .gitignore, and iOS docs for Swift AppDelegate integration

Reviewed Changes

Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/demo/android/build.gradle Updated SDK versions, buildToolsVersion, NDK, Kotlin
examples/demo/android/app/build.gradle Added Kotlin Android plugin, autolink config, JSC flavor
examples/demo/android/app/src/main/java/com/example/MainApplication.kt Added Kotlin MainApplication replacing Java version
examples/demo/android/app/src/main/java/com/example/MainActivity.kt Added Kotlin MainActivity replacing Java version
examples/demo/android/app/src/debug/AndroidManifest.xml Cleaned up debug manifest, removed DevSettingsActivity
examples/demo/tests/App.test.tsx Migrated to react-test-renderer and act for tests
examples/demo/App.tsx New TSX demo app with auth flows
examples/demo/Gemfile Pinned CocoaPods and Ruby gems to avoid known issues
examples/demo/CHANGELOG.md Deleted CHANGELOG (history removed)
docs/docs/introduction.md Updated iOS instructions to Swift bridging header
Comments suppressed due to low confidence (6)

examples/demo/android/app/build.gradle:119

  • Re-add the applyNativeModulesAppBuildGradle call to ensure all native modules are properly linked after autolinking.
apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)

examples/demo/android/app/src/debug/AndroidManifest.xml:6

  • Removing DevSettingsActivity may disable the in-app developer menu; confirm if this removal is intended.
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />

examples/demo/CHANGELOG.md:1

  • The entire CHANGELOG.md was deleted; consider preserving or updating the changelog to retain release history.
# rnaa-demo

examples/demo/android/build.gradle:16

  • Specify an explicit version for com.android.tools.build:gradle to ensure build reproducibility and avoid unexpected upgrades.
classpath("com.android.tools.build:gradle")

examples/demo/tests/App.test.tsx:10

  • [nitpick] The current test only covers initial render; consider adding tests for refresh and revoke flows to improve coverage of auth functionality.
await ReactTestRenderer.act(() => {

examples/demo/App.tsx:200

  • Remove this debug console.log that prints sensitive auth tokens to avoid leaking credentials in production.
console.log('>>>>>>>', JSON.stringify(authState, null, 2));

@zibs zibs merged commit 83423e0 into main May 27, 2025
3 checks passed
@zibs zibs deleted the chore/upgrade-demo-app branch May 27, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants