-
Notifications
You must be signed in to change notification settings - Fork 28
New Architecture support #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Would this PR open up the possibility to update to the latest version of RN (0.78.x at the time of writing) ? |
Description
First apologies for the amount of change in this PR. I don't expect it to be accepted at all in it's current form. I'm happy to work on getting it in a saner stated if needed.
I've just started using react-native-owl, so much easier than detox that I was using before.
However I was having issues with screenshots when using the React Native new architecture.
Immersive mode wasn't working.
I started working on supporting the new arch; I ended up basically trying to align everything with
react-native-create-library
to get it to work (as I use it for another library I work on), hence why there is so much change.Something I discovered when I was almost done converting to TurboModules, is that on new arch you need to call
TurboModuleRegistry.get
otherwise the initialize doesn't load.I've test this on the unreleased monorepo version of react-native-vector icons and it's working well for me.
Not all the tests are working yet, some issues with mocking.
I though I'd open this for feedback before I spent more time on it.
Type of Change
In theory this should be fully backwards compatible and not breaking.
How Has This Been Tested?
I've tested against
react-native-vector-icons
, I'll work on the inbuilt test suite next.Checklist: (Feel free to delete this section upon completion)
yarn prettier:apply
)yarn test
)