Expose magica voxel scene info #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Game4all
reviewed
Oct 12, 2023
assets/boy.vox
Outdated
There was a problem hiding this comment.
Just in case to not get into any legal trouble, what's the usage license for this ?
| return true; | ||
| } | ||
|
|
||
| pub fn to_entity( |
There was a problem hiding this comment.
I would rather have this called spawn or something along this at it effectively spawns an entity into the world.
Suggested change
| pub fn to_entity( | |
| pub fn spawn( |
Co-authored-by: Lucas Arriesse <game4allyt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read More info of vox file. save in a VoxMateData
and support helper fn to build entity for all models with relation in vox file.
example is in example/boy.rs